You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dan Tran <da...@gmail.com> on 2015/01/20 21:19:48 UTC

Maven Eclipse Java Formatter and Checkslyle

The current maven java formatter [1] keeps fluent statement in one line
with size larger than the limit 120

This case where I had to do a few manual hacks to make checkstyle happy for
PMD maven plugin

Should we fix the formatter?


Thanks

-D



[1] http://maven.apache.org/developers/maven-eclipse-codestyle.xml

Re: Maven Eclipse Java Formatter and Checkslyle

Posted by Kristian Rosenvold <kr...@gmail.com>.
Yes, we should fix the code style for this

2015-01-20 21:19 GMT+01:00 Dan Tran <da...@gmail.com>:
> The current maven java formatter [1] keeps fluent statement in one line
> with size larger than the limit 120
>
> This case where I had to do a few manual hacks to make checkstyle happy for
> PMD maven plugin
>
> Should we fix the formatter?
>
>
> Thanks
>
> -D
>
>
>
> [1] http://maven.apache.org/developers/maven-eclipse-codestyle.xml

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Maven Eclipse Java Formatter and Checkslyle

Posted by Hervé BOUTEMY <he...@free.fr>.
+1 if someone can fix this 120 limit

Le mardi 20 janvier 2015 15:23:02 Igor Fedorenko a écrit :
> I think we should. I also noticed the current formatter and checkstyle
> disagree about explicit type parameters like in
> 
>      Collections.<String>emptyList()
this one is already fixed in http://svn.apache.org/r1618763

> 
> I'd be happy to test the new formatter configuration.
so do I :)

Regards,

Hervé

> 
> --
> Regards,
> Igor
> 
> On 2015-01-20 15:19, Dan Tran wrote:
> > The current maven java formatter [1] keeps fluent statement in one line
> > with size larger than the limit 120
> > 
> > This case where I had to do a few manual hacks to make checkstyle happy
> > for
> > PMD maven plugin
> > 
> > Should we fix the formatter?
> > 
> > 
> > Thanks
> > 
> > -D
> > 
> > 
> > 
> > [1] http://maven.apache.org/developers/maven-eclipse-codestyle.xml
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Maven Eclipse Java Formatter and Checkslyle

Posted by Igor Fedorenko <ig...@ifedorenko.com>.
I think we should. I also noticed the current formatter and checkstyle
disagree about explicit type parameters like in

     Collections.<String>emptyList()

I'd be happy to test the new formatter configuration.

--
Regards,
Igor

On 2015-01-20 15:19, Dan Tran wrote:
> The current maven java formatter [1] keeps fluent statement in one line
> with size larger than the limit 120
>
> This case where I had to do a few manual hacks to make checkstyle happy for
> PMD maven plugin
>
> Should we fix the formatter?
>
>
> Thanks
>
> -D
>
>
>
> [1] http://maven.apache.org/developers/maven-eclipse-codestyle.xml
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org