You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bbonnin <gi...@git.apache.org> on 2016/01/16 18:54:16 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
GitHub user bbonnin opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/646
ZEPPELIN-602 elasticsearch throws ArrayIndexOutOfBoundsException
### What is this PR for?
Fix for https://issues.apache.org/jira/browse/ZEPPELIN-602
"elasticsearch throws ArrayIndexOutOfBoundsException for interpreting an empty paragraph"
### What type of PR is it?
Bug Fix
### Todos
* [X] - Code : check cmd parameter
### Is there a relevant Jira issue?
ZEPPELIN-602
### How should this be tested?
Start elasticsearch interpreter with an empty paragraph
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbonnin/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #646
----
commit 765164787efcad0ff7c27f8627b03e4c3fbd4578
Author: Bruno Bonnin <bb...@gmail.com>
Date: 2016-01-16T17:48:22Z
ZEPPELIN-602 elasticsearch throws ArrayIndexOutOfBoundsException for interpreting an empty paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172247147
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172998910
my bad - i didn't figure that. @bbonnin now you are all set - thanks and looking forward to your future contributions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by bbonnin <gi...@git.apache.org>.
Github user bbonnin commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172250816
I have added unit tests for the fix (and add a complement for the fix).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172970085
I'm getting error with that though in ASF JIRA:
```
User 'bbonnin' cannot be assigned issues.
```
Could you check: https://issues.apache.org/jira/browse/ZEPPELIN-602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172753798
@bbonnin let me know if you'd like to be marked as assignee in the JIRA. Thanks for making this fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172371433
And I could merge this if we have no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172279052
great! thanks for jumping in on this, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172974258
@felixcheung You'll need add 'bbonnin' in 'Contributors' section in https://issues.apache.org/jira/plugins/servlet/project-config/ZEPPELIN/roles page. Then issue can be assigned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by bbonnin <gi...@git.apache.org>.
Github user bbonnin commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172769371
My JIRA id is bbonnin. And you can assign me the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-602 elasticsearch throws...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/646#issuecomment-172341989
@bbonnin Do you have a JIRA id (issues.apache.org)? I'd like to mark you as an assignee of https://issues.apache.org/jira/browse/ZEPPELIN-602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---