You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pekko.apache.org by md...@apache.org on 2023/02/21 14:33:53 UTC

[incubator-pekko-http] branch main updated: Move header check into its own github actions workflow

This is an automated email from the ASF dual-hosted git repository.

mdedetrich pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-pekko-http.git


The following commit(s) were added to refs/heads/main by this push:
     new 193390db8 Move header check into its own github actions workflow
193390db8 is described below

commit 193390db8963dfeeadeb79974ddad2763bb7c7ce
Author: Matthew de Detrich <ma...@aiven.io>
AuthorDate: Tue Feb 21 12:36:40 2023 +0100

    Move header check into its own github actions workflow
---
 .github/workflows/check-headers.yml     | 29 +++++++++++++++++++++++++++++
 .github/workflows/validate-and-test.yml |  3 ---
 build.sbt                               |  1 -
 project/CopyrightHeader.scala           |  4 +---
 4 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/check-headers.yml b/.github/workflows/check-headers.yml
new file mode 100644
index 000000000..d990cac6f
--- /dev/null
+++ b/.github/workflows/check-headers.yml
@@ -0,0 +1,29 @@
+name: Headers
+
+on:
+  pull_request:
+
+permissions: {}
+
+jobs:
+  check-headers:
+    name: Check headers
+    runs-on: ubuntu-20.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Setup Java 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: temurin
+          java-version: 8
+
+      - name: Cache Coursier cache
+        uses: coursier/cache-action@v6.4.0
+
+      - name: Enable jvm-opts
+        run: cp .jvmopts-ghactions .jvmopts
+
+      - name: Check headers
+        run: sbt +headerCheckAll
diff --git a/.github/workflows/validate-and-test.yml b/.github/workflows/validate-and-test.yml
index 1c1bd24a5..5bef27cca 100644
--- a/.github/workflows/validate-and-test.yml
+++ b/.github/workflows/validate-and-test.yml
@@ -34,9 +34,6 @@ jobs:
           path: project/**/target
           key: build-target-${{ hashFiles('**/*.sbt', 'project/build.properties', 'project/**/*.scala') }}
 
-      - name: Check headers
-        run: sbt headerCheckAll
-
       - name: Check for missing formatting
         run: git diff --exit-code --color
 
diff --git a/build.sbt b/build.sbt
index bec10e7dc..91f6ec80d 100644
--- a/build.sbt
+++ b/build.sbt
@@ -236,7 +236,6 @@ lazy val httpTests = project("http-tests")
   .disablePlugins(MimaPlugin) // this is only tests
   .configs(MultiJvm)
   .settings(headerSettings(MultiJvm))
-  .settings(ValidatePR / additionalTasks += MultiJvm / headerCheck)
   .addPekkoModuleDependency("pekko-stream", "provided")
   .addPekkoModuleDependency("pekko-multi-node-testkit", "test")
   .settings(
diff --git a/project/CopyrightHeader.scala b/project/CopyrightHeader.scala
index dd73952a9..f3758ad0b 100644
--- a/project/CopyrightHeader.scala
+++ b/project/CopyrightHeader.scala
@@ -33,9 +33,7 @@ object CopyrightHeader extends AutoPlugin {
             HeaderFileType.scala -> cStyleComment,
             HeaderFileType.java -> cStyleComment,
             HeaderFileType("template") -> cStyleComment)))
-    },
-    ValidatePR / additionalTasks += Compile / headerCheck,
-    ValidatePR / additionalTasks += Test / headerCheck)
+    })
 
   val apacheHeader: String =
     """Licensed to the Apache Software Foundation (ASF) under one or more


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org