[GitHub] [spark] MaxGekk commented on a diff in pull request #36855: [SPARK-39432][SQL] Return ELEMENT_AT_BY_INDEX_ZERO from element_at(*, 0)

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #36855:
URL: https://github.com/apache/spark/pull/36855#discussion_r906802441


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -70,6 +70,11 @@
     ],
     "sqlState" : "23000"
   },
+  "ELEMENT_AT_BY_INDEX_ZERO" : {
+    "message" : [
+      "The index 0 is invalid. The indexes can be < 0 and > 0 (the first element has index 1)."

Review Comment:
   `and` might confuse users. Could you write this in more straight way:
   "... An index shall be either < 0 or > 0 (the first element has index 1)."



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org