You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2018/01/17 15:52:00 UTC

[GitHub] rombert commented on issue #3: SLING-7346: handle JSONResponse properties as json if possible.

rombert commented on issue #3: SLING-7346: handle JSONResponse properties as json if possible.
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/3#issuecomment-358347590
 
 
   This basically looks ok to me. My only slight worry is that the JsonReponse may be used as an implementation of the PostResponse interface and such exceptions may be opaque. On the other hand, setting invalid JSON as property values would be leading to problems anyway so we just report the problem earlier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services