You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/07 15:48:47 UTC

[GitHub] [flink] lqjack commented on a change in pull request #15812: remove slotpoolImpl

lqjack commented on a change in pull request #15812:
URL: https://github.com/apache/flink/pull/15812#discussion_r628328419



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultSlotPoolServiceFactory.java
##########
@@ -38,6 +38,7 @@ public DefaultSlotPoolServiceFactory(
     @Override
     @Nonnull
     public SlotPoolService createSlotPoolService(@Nonnull JobID jobId) {
-        return new SlotPoolImpl(jobId, clock, rpcTimeout, slotIdleTimeout, batchSlotTimeout);
+        return new DeclarativeSlotPoolService(

Review comment:
       thanks. I will change it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org