You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/03/02 04:22:30 UTC
[PR] Unpinning fastapi version as new version is released (0.115.11) [airflow]
amoghrajesh opened a new pull request, #47266:
URL: https://github.com/apache/airflow/pull/47266
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
#47233 pinned fastapi due to a bug in 0.115.10. That bug has been fixed and 0.115.11 is released: https://github.com/fastapi/fastapi/releases/tag/0.115.11
Undoing that change.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unpinning fastapi version as new version is released (0.115.11) [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #47266:
URL: https://github.com/apache/airflow/pull/47266#discussion_r1976554211
##########
hatch_build.py:
##########
@@ -370,8 +370,7 @@
# Required for python 3.9 to work with new annotations styles. Check package
# description on PyPI for more details: https://pypi.org/project/eval-type-backport/
'eval-type-backport>=0.2.0;python_version<"3.10"',
- # temporarily pinning fastapi after the recent release started breaking tests
- "fastapi[standard]>=0.112.2,!=0.115.10",
Review Comment:
I do not think we should do it. They have not yanked 0.115.10 and that exclusion is actually correct - we will still get 0.115.11 and we will skip 0.115.10 - which for us is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding comment explaining why we exclude 0.115.10 fastapi [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47266:
URL: https://github.com/apache/airflow/pull/47266#issuecomment-2692602328
Yep. This is cool now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding comment explaining why we exclude 0.115.10 fastapi [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #47266:
URL: https://github.com/apache/airflow/pull/47266#issuecomment-2692602697
And it works as expected:
<img width="399" alt="Screenshot 2025-03-02 at 08 34 48" src="https://github.com/user-attachments/assets/2f8262d4-0ac5-43c7-8c1d-c06e42535c60" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding comment explaining why we exclude 0.115.10 fastapi [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #47266:
URL: https://github.com/apache/airflow/pull/47266#discussion_r1976555384
##########
hatch_build.py:
##########
@@ -370,8 +370,7 @@
# Required for python 3.9 to work with new annotations styles. Check package
# description on PyPI for more details: https://pypi.org/project/eval-type-backport/
'eval-type-backport>=0.2.0;python_version<"3.10"',
- # temporarily pinning fastapi after the recent release started breaking tests
- "fastapi[standard]>=0.112.2,!=0.115.10",
Review Comment:
Thanks. I just updated the PR to add a comment as to why we skip 0.115.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Adding comment explaining why we exclude 0.115.10 fastapi [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #47266:
URL: https://github.com/apache/airflow/pull/47266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org