[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16005: [Issue 15896] Fix LockTimeout when storePut on the same key concurrently in RocksdbMetadataStore

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #16005:
URL: https://github.com/apache/pulsar/pull/16005#discussion_r894488726


##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java:
##########
@@ -447,4 +448,33 @@ public void run() {
         assertEquals(successWrites.get(), maxValue);
         assertEquals(store.get(path).get().get().getValue()[0], maxValue);
     }
+
+    @Test(dataProvider = "impl")
+    public void testConcurrentPut(String provider, Supplier<String> urlSupplier) throws Exception {
+        MetadataStore store = MetadataStoreFactory.create(urlSupplier.get(), MetadataStoreConfig.builder().build());

Review Comment:
   Need to close the store after test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org