You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/01/19 01:28:33 UTC
[GitHub] [mynewt-core] jeremywood opened a new pull request #2456: Update lwip_base to LWIP 2.1.2
jeremywood opened a new pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456
Update the Mynewt `lwip_base` package from 2.0.3 to 2.1.2, the latest release version of LWIP.
Minimal changes to the 2.1.2 sources, all detailed in the updated `net/ip/lwip_base/MYNEWT`.
So far, I've tested on nRF52840 with PPPoS, no issues found. Would be great to have others test on other HW!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-762544711
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] jeremywood commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
jeremywood commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-770453507
@sjanc I'm not sure what happened with the CI errors, but I think this is ready to merge if you're happy with the commit history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-762544711
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane edited a comment on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
vrahane edited a comment on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724
Next step is merging it @jeremywood. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] utzig commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
utzig commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-770499759
> @sjanc I'm not sure what happened with the CI errors, but I think this is ready to merge if you're happy with the commit history.
I think you can just disregard the CI for now, Travis needs to be migrated from .org to .com; I'll check how to proceed with that before it happens automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724
Next step is merging it @jeremywood.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] jeremywood commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
jeremywood commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-770012295
@sjanc Thanks for the feedback—I agree, it's cleaner to combine those commits, which I've done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane edited a comment on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
vrahane edited a comment on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724
Next step is merging it @jeremywood. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-773202724
Next step is merging it @jeremywood.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-772577316
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] jeremywood commented on pull request #2456: Update lwip_base to LWIP 2.1.2
Posted by GitBox <gi...@apache.org>.
jeremywood commented on pull request #2456:
URL: https://github.com/apache/mynewt-core/pull/2456#issuecomment-772714113
What's the next step with this PR? I'm eager to get it merged so that I go back to tracking master instead of my fork.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org