You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Miroslav Smiljanic (Jira)" <ji...@apache.org> on 2022/09/15 08:37:00 UTC

[jira] [Commented] (OAK-9936) Optimize AzureJournalWriter#batchWriteLines()

    [ https://issues.apache.org/jira/browse/OAK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605200#comment-17605200 ] 

Miroslav Smiljanic commented on OAK-9936:
-----------------------------------------

[~jelmini] thank you for this valuable contribution. I have merged the PR. 

> Optimize AzureJournalWriter#batchWriteLines()
> ---------------------------------------------
>
>                 Key: OAK-9936
>                 URL: https://issues.apache.org/jira/browse/OAK-9936
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-azure
>    Affects Versions: 1.44.0
>            Reporter: Carlo Jelmini
>            Assignee: Miroslav Smiljanic
>            Priority: Major
>
> The implementation of {{AzureJournalWriter#batchWriteLines}} (inside {{{}AzureJournalFile{}}}) is very inefficient. If the batch size is high, it can take minutes to complete. The issue is that {{batchWriteLines()}} simply delegates to {{{}writeLine(){}}}, which uploads each single line (and metadata) to the blob.
> We should implement {{batchWriteLines() }}by uploading multiple lines in one call.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)