You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 06:33:49 UTC

[GitHub] [flink] zhuzhurk commented on a change in pull request #12256: [FLINK-17018][runtime] DefaultExecutionSlotAllocator allocates slots in bulks

zhuzhurk commented on a change in pull request #12256:
URL: https://github.com/apache/flink/pull/12256#discussion_r429753738



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SingleLogicalSlot.java
##########
@@ -168,6 +185,11 @@ public void release(Throwable cause) {
 		releaseFuture.complete(null);
 	}
 
+	@Override
+	public boolean willOccupySlotIndefinitely() {

Review comment:
       It is intentional.
   SingleLogicalSlot has 2 roles. One is logical slot and the other is physical slot payload.
   It will occupy a physical slot indefinitely iff it will be occupied indefinitely by a task.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org