You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/27 05:58:59 UTC

[GitHub] codecov-io commented on issue #6764: Add feature flag for allowing any column to be filterable or groupable

codecov-io commented on issue #6764: Add feature flag for allowing any column to be filterable or groupable
URL: https://github.com/apache/incubator-superset/pull/6764#issuecomment-457891605
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=h1) Report
   > Merging [#6764](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a62a8d3d985ed7343fe83540e5cdcbb1474ac6ac?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6764/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #6764      +/-   ##
   ==========================================
   - Coverage   56.07%   56.07%   -0.01%     
   ==========================================
     Files         525      525              
     Lines       23220    23224       +4     
     Branches     2777     2777              
   ==========================================
   + Hits        13020    13022       +2     
   - Misses       9791     9793       +2     
     Partials      409      409
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/6764/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.54% <100%> (ø)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6764/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.88% <50%> (-0.21%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=footer). Last update [a62a8d3...368a5c1](https://codecov.io/gh/apache/incubator-superset/pull/6764?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org