You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/26 09:09:18 UTC
[GitHub] flink pull request #4398: [FLINK-7249] [build] Bump java.version property to...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4398
[FLINK-7249] [build] Bump java.version property to 1.8
This PR is based on #4388 .
It bumps the java.version property used by the maven-compiler-plugin and quickstarts to 1.8 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7249
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4398.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4398
----
commit 3aa97b9d0ede97f04fd33a24c8c8776cc96551fb
Author: zentol <ch...@apache.org>
Date: 2017-07-24T10:34:17Z
[FLINK-7247] [travis] Replace java 7 build profiles
commit 52729e7148668505e5c57dd6872898f38c96b03e
Author: zentol <ch...@apache.org>
Date: 2017-07-24T11:13:34Z
[FLINK-7249] [build] Bump java.version property to 1.8
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4398: [FLINK-7249] [build] Bump java.version property to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4398: [FLINK-7249] [build] Bump java.version property to 1.8
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4398
@greghogan Nice catch, i completely forgot about possible references in the docs. I modified the files you mentioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4398: [FLINK-7249] [build] Bump java.version property to 1.8
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4398
+1 to merge
We can also simplify setting the garbage collector in `flink-dist/src/main/flink-bin/bin/taskmanager.sh` and including the `flink-connector-elasticsearch5` module in `flink-connectors/pom.xml`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4398: [FLINK-7249] [build] Bump java.version property to 1.8
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4398
I've created JIRAs for addressing the issues you found.
Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4398: [FLINK-7249] [build] Bump java.version property to 1.8
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4398
Also need to update the documentation.
$ grep -lir "java 7" docs/
docs//quickstart/java_api_quickstart.md
docs//quickstart/scala_api_quickstart.md
docs//quickstart/setup_quickstart.md
docs//setup/building.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---