You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/29 08:08:00 UTC

[GitHub] [flink-kubernetes-operator] wangyang0918 opened a new pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

wangyang0918 opened a new pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127


   Backport #125 to release-0.1 branch


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] zentol commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081655620


   @wangyang0918 @gyfora How do you intend to handle the licensing of the reporter jars that you're embedding into the image? (https://github.com/apache/flink-kubernetes-operator/blob/main/flink-kubernetes-operator/pom.xml)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081945726


   @zentol thanks for looking into this. I agree that the current setup could be improved, and support @wangyang0918's suggestion to solve this for 1.0.0, and live with it for 0.1.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081672865


   @zentol we could include this in the notice for the operator as well, but since the jars contain the notices themselves we don't really need to do this. Anyone checking the contents of the container should be able to discover these notices. Thet are not part of any bundle that we publist to dist.apache.org. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081724900


   I have created a ticket FLINK-26914 to track the NOTICE file improvements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081560301


   Will merge this PR after CI passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
wangyang0918 merged pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora edited a comment on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
gyfora edited a comment on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081672865


   @zentol we could include this in the notice for the operator as well, but since the jars contain the notices themselves we don't really need to do this. Anyone checking the contents of the container should be able to discover these notices. They are not part of any bundle that we publist to dist.apache.org. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
gyfora commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081680907


   We can open a jira for this to make it nicer for 1.0.0 together with other NOTICE improvements


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] zentol commented on pull request #127: [BP-0.1] [FLINK-26903] Add correct NOTICE file to flink-kubernetes-operator

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #127:
URL: https://github.com/apache/flink-kubernetes-operator/pull/127#issuecomment-1081658213


   Having the jars contain the NOTICE files is imo insufficient as discoverability within the image is basically 0. You should extract & merge the NOTICE files for all jars, similarly to what we do for flink-dist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org