You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/28 07:46:51 UTC
[GitHub] [spark] itholic opened a new pull request, #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
itholic opened a new pull request, #39260:
URL: https://github.com/apache/spark/pull/39260
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This PR proposes to assign name to _LEGACY_ERROR_TEMP_1249, "NOT_A_PARTITIONED_TABLE".
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We should assign proper name to _LEGACY_ERROR_TEMP_*
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
URL: https://github.com/apache/spark/pull/39260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1058980747
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2405,22 +2405,24 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
messageParameters = Map.empty)
}
- def cmdOnlyWorksOnPartitionedTablesError(cmd: String, tableIdentWithDB: String): Throwable = {
+ def cmdOnlyWorksOnPartitionedTablesError(
+ operation: String,
+ tableIdentWithDB: String): Throwable = {
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1249",
+ errorClass = "NOT_A_PARTITIONED_TABLE",
messageParameters = Map(
- "cmd" -> cmd,
+ "operation" -> operation,
Review Comment:
Please, quote it using `toSQLStmt()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1073551736
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -961,6 +961,11 @@
],
"sqlState" : "42000"
},
+ "NOT_A_PARTITIONED_TABLE" : {
+ "message" : [
+ "Operation <operation> is not allowed for <tableIdentWithDB> because it is not a partitioned table."
Review Comment:
Let me handle this when I submit another error message improvement PR.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1062073949
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2405,22 +2405,24 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
messageParameters = Map.empty)
}
- def cmdOnlyWorksOnPartitionedTablesError(cmd: String, tableIdentWithDB: String): Throwable = {
+ def cmdOnlyWorksOnPartitionedTablesError(
+ operation: String,
+ tableIdentWithDB: String): Throwable = {
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1249",
+ errorClass = "NOT_A_PARTITIONED_TABLE",
messageParameters = Map(
- "cmd" -> cmd,
+ "operation" -> toSQLStmt(operation),
"tableIdentWithDB" -> tableIdentWithDB))
}
- def cmdOnlyWorksOnTableWithLocationError(cmd: String, tableIdentWithDB: String): Throwable = {
+ def cmdOnlyWorksOnTableWithLocationError(
Review Comment:
Oh... yeah seems like we should introduce new error class.
Just turned this error into `_LEGACY_ERROR_TEMP_2446`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39260:
URL: https://github.com/apache/spark/pull/39260#issuecomment-1386731376
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1073280556
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -961,6 +961,11 @@
],
"sqlState" : "42000"
},
+ "NOT_A_PARTITIONED_TABLE" : {
+ "message" : [
+ "Operation <operation> is not allowed for <tableIdentWithDB> because it is not a partitioned table."
Review Comment:
`qualifiedTableName` is better than `tableIdentWithDB` but it's minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1061672988
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2405,22 +2405,24 @@ private[sql] object QueryCompilationErrors extends QueryErrorsBase {
messageParameters = Map.empty)
}
- def cmdOnlyWorksOnPartitionedTablesError(cmd: String, tableIdentWithDB: String): Throwable = {
+ def cmdOnlyWorksOnPartitionedTablesError(
+ operation: String,
+ tableIdentWithDB: String): Throwable = {
new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1249",
+ errorClass = "NOT_A_PARTITIONED_TABLE",
messageParameters = Map(
- "cmd" -> cmd,
+ "operation" -> toSQLStmt(operation),
"tableIdentWithDB" -> tableIdentWithDB))
}
- def cmdOnlyWorksOnTableWithLocationError(cmd: String, tableIdentWithDB: String): Throwable = {
+ def cmdOnlyWorksOnTableWithLocationError(
Review Comment:
This is another error, isn't it? It is about location not about partitioning. Please, fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1063982811
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -2166,6 +2166,22 @@ abstract class DDLSuite extends QueryTest with DDLSuiteBase {
assert(spark.sessionState.catalog.isRegisteredFunction(rand))
}
}
+
+ test("NOT_A_PARTITIONED_TABLE: ALTER TABLE is not allowed for non-partitioned table") {
Review Comment:
Precisely speaking, `ALTER TABLE .. RECOVER PARTITIONS` not just `ALTER TABLE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a diff in pull request #39260: [SPARK-41579][SQL] Assign name to _LEGACY_ERROR_TEMP_1249
Posted by GitBox <gi...@apache.org>.
itholic commented on code in PR #39260:
URL: https://github.com/apache/spark/pull/39260#discussion_r1064249717
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala:
##########
@@ -2166,6 +2166,22 @@ abstract class DDLSuite extends QueryTest with DDLSuiteBase {
assert(spark.sessionState.catalog.isRegisteredFunction(rand))
}
}
+
+ test("NOT_A_PARTITIONED_TABLE: ALTER TABLE is not allowed for non-partitioned table") {
Review Comment:
Just moved the test into dedicated test suites, and update the test name.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org