You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2016/07/12 10:02:20 UTC
[jira] [Comment Edited] (LUCENE-7372) factor out a
org.apache.lucene.search.FilterWeight class
[ https://issues.apache.org/jira/browse/LUCENE-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372633#comment-15372633 ]
Christine Poerschke edited comment on LUCENE-7372 at 7/12/16 10:02 AM:
-----------------------------------------------------------------------
bq. Can you add @lucene.internal to the class javadocs ...
Just to confirm, {{@lucene.internal}} or {{@lucene.experimental}} or perhaps both?
I notice that {{FilterCollector}} and {{FilterLeafCollector}} are marked {{@lucene.experimental}} but other [org.apache.lucene.search|https://github.com/apache/lucene-solr/tree/master/lucene/core/src/java/org/apache/lucene/search] Filter classes are unmarked.
Should they ({{FilteredDocIdSetIterator}}, {{FilterScorer}}, {{FilterSpans}}) be marked also and if so (outside the scope of this ticket) as what?
Similar question would apply to [org.apache.lucene.index|https://github.com/apache/lucene-solr/tree/master/lucene/core/src/java/org/apache/lucene/index] Filter classes e.g. {{FilterCodecReader}}, {{FilterDirectoryReader}}, {{FilteredTermsEnum}}, {{FilterLeafReader}} and possibly other classes too.
was (Author: cpoerschke):
bq. Can you add @lucene.internal to the class javadocs ...
Just to confirm, {{@lucene.internal}} or {{@lucene.experimental}} or perhaps both?
I notice that {{FilterCollector}} and {{FilterLeafCollector}} are marked {{@lucene.experimental}} but other [org.apache.lucene.search|https://github.com/apache/lucene-solr/tree/master/lucene/core/src/java/org/apache/lucene/search] Filter classes are unmarked.
Should they ({{FilteredDocIdSetIterator}}, {{FilterLeafCollector}}, {{FilterScorer}}, {{FilterSpans}}) be marked also and if so (outside the scope of this ticket) as what?
Similar question would apply to [org.apache.lucene.index|https://github.com/apache/lucene-solr/tree/master/lucene/core/src/java/org/apache/lucene/index] Filter classes e.g. {{FilterCodecReader}}, {{FilterDirectoryReader}}, {{FilteredTermsEnum}}, {{FilterLeafReader}} and possibly other classes too.
> factor out a org.apache.lucene.search.FilterWeight class
> --------------------------------------------------------
>
> Key: LUCENE-7372
> URL: https://issues.apache.org/jira/browse/LUCENE-7372
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7372.patch, LUCENE-7372.patch, LUCENE-7372.patch
>
>
> * {{FilterWeight}} to delegate method implementations to the {{Weight}} that it wraps
> * exception: no delegating for the {{bulkScorer}} method implementation since currently not all FilterWeights implement/override that default method
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org