Re: [PR] IGNITE-27141 Remove txStateStorage from table [ignite-3]

["sk0x50 (via GitHub)" <gi...@apache.org>]

sk0x50 commented on code in PR #7171:
URL: https://github.com/apache/ignite-3/pull/7171#discussion_r2602036549


##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/OnSnapshotSaveHandler.java:
##########
@@ -60,7 +60,9 @@ public CompletableFuture<Void> onSnapshotSave(PartitionSnapshotInfo snapshotInfo
 
         tableProcessors.forEach(processor -> processor.lastApplied(lastAppliedIndex, lastAppliedTerm));
 
-        txStatePartitionStorage.lastApplied(lastAppliedIndex, lastAppliedTerm);
+        if (txStatePartitionStorage != null) {

Review Comment:
   `txStatePartitionStorage` cannot be `null`, so this check is redundant.



##########
modules/table/src/testFixtures/java/org/apache/ignite/distributed/ItTxTestCluster.java:
##########
@@ -947,89 +941,61 @@ private ReplicaListener getOrCreateAndPopulateReplicaListenerProvider(
             RemotelyTriggeredResourceRegistry resourcesRegistry,
             SchemaRegistry schemaRegistry
     ) {
-        if (colocationEnabled()) {
-            var nodeSpecificZonePartitionReplicaListeners = zonePartitionReplicaListeners.computeIfAbsent(assignment, k -> new HashMap<>());
-
-            ZonePartitionReplicaListener zonePartitionReplicaListener = nodeSpecificZonePartitionReplicaListeners.computeIfAbsent(
-                    zonePartitionId,
-                    partitionId -> new ZonePartitionReplicaListener(
-                            txStatePartitionStorage,
-                            clockService,
-                            txManager,
-                            validationSchemasSource,
-                            schemaSyncService,
-                            catalogService,
-                            placementDriver,
-                            clusterNodeResolver,
-                            raftClient,
-                            new NoOpFailureManager(),
-                            localNode,
-                            partitionId
-                    )
-            );
+        var nodeSpecificZonePartitionReplicaListeners = zonePartitionReplicaListeners.computeIfAbsent(assignment, k -> new HashMap<>());

Review Comment:
   Minor: Using `var` here should be avoided due to code style.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org