You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by nickwallen <gi...@git.apache.org> on 2018/05/25 17:38:22 UTC
[GitHub] metron pull request #1034: METRON-1580 Release candidate check script requir...
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1034
METRON-1580 Release candidate check script requires Bro Plugin
Not all Metron releases will include a new version of the Bro Plugin. The release candidate script currently requires it though. These changes make the `--bro` argument option which allows us to validate releases which do not contain an updated Bro plugin.
## Testing
```
./dev-utilities/release-utils/metron-rc-check --version=0.5.0 --candidate=RC1
```
## Pull Request Checklist
- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
- [ ] Have you written or updated unit tests and or integration tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nickwallen/metron METRON-1580
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1034
----
commit 2e8283d1bb2372128bc077f7253f67180890f875
Author: Nick Allen <ni...@...>
Date: 2018-05-25T17:35:58Z
METRON-1580 Release candidate check script requires Bro Plugin
----
---
[GitHub] metron issue #1034: METRON-1580 Release candidate check script requires Bro ...
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1034
+1 by inspection, thanks @nickwallen
---
[GitHub] metron pull request #1034: METRON-1580 Release candidate check script requir...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1034
---