[GitHub] [druid] vogievetsky commented on a change in pull request #10794: Web console: Remove first / last suggestions

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #10794:
URL: https://github.com/apache/druid/pull/10794#discussion_r563954782



##########
File path: web-console/src/druid-models/metric-spec.tsx
##########
@@ -67,14 +67,17 @@ export const METRIC_SPEC_FIELDS: Field<MetricSpec>[] = [
         group: 'max',
         suggestions: ['longMax', 'doubleMax', 'floatMax'],
       },
-      {
-        group: 'first',
-        suggestions: ['longFirst', 'doubleFirst', 'floatFirst'],
-      },
-      {
-        group: 'last',
-        suggestions: ['longLast', 'doubleLast', 'floatLast'],
-      },
+      // Do not show first and last aggregators as they can not be used in ingestion specs and this definition is only used in the data loader.
+      // Ref: https://druid.apache.org/docs/latest/querying/aggregations.html#first--last-aggregator
+      // Should the first / last aggregators become usable at ingestion time, comment in the lines below:
+      // {
+      //   group: 'first',
+      //   suggestions: ['longFirst', 'doubleFirst', 'floatFirst'],
+      // },
+      // {
+      //   group: 'last',
+      //   suggestions: ['longLast', 'doubleLast', 'floatLast'],
+      // },

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org