[jira] [Comment Edited] (TS-2032) Set milestone for cache-lookup times

["John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539917#comment-14539917 ] 

John edited comment on TS-2032 at 5/12/15 2:41 PM:
---------------------------------------------------

Attached is my patch for TS-2032.  I added an http stat milestone called proxy.process.http.milestone.cache_lookup_time which accumulates cache lookup time in milliseconds.  Here is an example of my test using the stats_over_http plugin to gather the statistics, note that cache_lookup_time has accumulated 6ms after some testing:

NOTE:  I found that proxy.process.http.cache_lookups exists already.

proxy.process.http.milestone.cache_open_read_end: "11",
proxy.process.http.milestone.cache_lookup_time: "6",
proxy.process.http.milestone.cache_open_write_begin: "1",
proxy.process.http.milestone.cache_open_write_end: "1",


was (Author: jrushford):
Attached is my patch for TS-2032.  I added an http stat milestone called proxy.process.http.milestone.cache_lookup_time which accumulates cache lookup time in milliseconds.  Here is an example of my test using the stats_over_http plugin to gather the statistics, note that cache_lookup_time has accumulated 6ms after some testing:

NOTE:  If found that proxy.process.http.cache_lookups exists already.

proxy.process.http.milestone.cache_open_read_end: "11",
proxy.process.http.milestone.cache_lookup_time: "6",
proxy.process.http.milestone.cache_open_write_begin: "1",
proxy.process.http.milestone.cache_open_write_end: "1",

> Set milestone for cache-lookup times
> ------------------------------------
>
>                 Key: TS-2032
>                 URL: https://issues.apache.org/jira/browse/TS-2032
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Metrics
>            Reporter: Leif Hedstrom
>            Assignee: John
>             Fix For: 6.0.0
>
>         Attachments: TS-2032.diff
>
>
> There was some plumbing for this in HttpSM.cc (grep for this bug #), but it was never used.  I left the code uncommented, and we can maybe add this back later. It might also need a metric for the number of cache lookups done as well (not sure we have one).
> This is also related to TS-1820, where this was cleaned out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)