[GitHub] [incubator-superset] willbarrett commented on a change in pull request #8773: re-enable Pylint on a number of view files

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #8773: re-enable Pylint on a number of view files
URL: https://github.com/apache/incubator-superset/pull/8773#discussion_r356167019
 
 

 ##########
 File path: superset/views/sql_lab.py
 ##########
 @@ -126,11 +127,11 @@ class SavedQueryView(SupersetModelView, DeleteMixin):
 
     show_template = "superset/models/savedquery/show.html"
 
-    def pre_add(self, obj):
-        obj.user = g.user
+    def pre_add(self, item):
 
 Review comment:
   +1 - the issue is the difference in signature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org