[GitHub] [flink] zentol commented on a change in pull request #8761: [FLINK-12842][network] Fix invalid check released state during ResultPartition#createSubpartitionView

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #8761: [FLINK-12842][network] Fix invalid check released state during ResultPartition#createSubpartitionView
URL: https://github.com/apache/flink/pull/8761#discussion_r295222304
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManagerTest.java
 ##########
 @@ -55,9 +49,24 @@ public void testThrowPartitionNotFoundException() throws Exception {
 	@Test
 	public void testCreateViewForRegisteredPartition() throws Exception {
 		final ResultPartitionManager partitionManager = new ResultPartitionManager();
-		final ResultPartition partition = PartitionTestUtils.createPartition();
+		final ResultPartition partition = createPartition();
 
 		partitionManager.registerResultPartition(partition);
 		partitionManager.createSubpartitionView(partition.getPartitionId(), 0, new NoOpBufferAvailablityListener());
 	}
+
+	/**
+	 * Tests {@link ResultPartitionManager#createSubpartitionView(ResultPartitionID, int, BufferAvailabilityListener)}
+	 * would throw a {@link PartitionNotFoundException} if this partition was already released before.
+	 */
+	@Test
+	public void testCreateViewForReleasePartition() throws Exception {
 
 Review comment:
   ´...ForReleasedPartition`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services