[jira] [Commented] (HADOOP-8450) Remove src/test/system

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288047#comment-13288047 ] 

Hadoop QA commented on HADOOP-8450:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12530663/hadoop-8450.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 111 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1073//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1073//console

This message is automatically generated.
                
> Remove src/test/system
> ----------------------
>
>                 Key: HADOOP-8450
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8450
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Eli Collins
>            Priority: Trivial
>         Attachments: hadoop-8450.txt
>
>
> runAs is a binary in the hadoop-common project.  It seems to allow you to run a hadoop daemon as another user.  However, it requires setuid privileges in order to do this.
> * Do we still need this binary?  Who is using it and are there better solutions out there?  My understanding is that setuid binaries are something we generally try to avoid.
> * If we do need it, can we add some documentation about it somewhere?
> * Should this binary be in the src/test directory?  It doesn't seem to be testing anything.
> Hopefully that covers everything...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira