You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (Created) (JIRA)" <ji...@apache.org> on 2011/11/24 18:03:41 UTC
[jira] [Created] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long]
package private for DocValues
Make BytesRef.copy[Int,Short,Long] package private for DocValues
----------------------------------------------------------------
Key: LUCENE-3591
URL: https://issues.apache.org/jira/browse/LUCENE-3591
Project: Lucene - Java
Issue Type: Sub-task
Affects Versions: 4.0
Reporter: Simon Willnauer
Fix For: 4.0
currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values we can still open this up if it is needed by other packages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long]
package private for DocValues
Posted by "Simon Willnauer (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer reassigned LUCENE-3591:
---------------------------------------
Assignee: Simon Willnauer
> Make BytesRef.copy[Int,Short,Long] package private for DocValues
> ----------------------------------------------------------------
>
> Key: LUCENE-3591
> URL: https://issues.apache.org/jira/browse/LUCENE-3591
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3591.patch
>
>
> currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values we can still open this up if it is needed by other packages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long]
package private for DocValues
Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156827#comment-13156827 ]
Robert Muir commented on LUCENE-3591:
-------------------------------------
+1
I think in most cases people that want to do this are happy with ByteArrayDataInput/Output, its reusable
and supports the DataInput/Output API completely. So most existing consumers that want to write a long
to a bytearray referred by a BytesRef are using these classes.
But for DV this is a good solution, removes some 'non-ref' APIs/minimizes our API exposure.
> Make BytesRef.copy[Int,Short,Long] package private for DocValues
> ----------------------------------------------------------------
>
> Key: LUCENE-3591
> URL: https://issues.apache.org/jira/browse/LUCENE-3591
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3591.patch
>
>
> currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values we can still open this up if it is needed by other packages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long]
package private for DocValues
Posted by "Simon Willnauer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer resolved LUCENE-3591.
-------------------------------------
Resolution: Fixed
committed to trunk in rev. 1205937
> Make BytesRef.copy[Int,Short,Long] package private for DocValues
> ----------------------------------------------------------------
>
> Key: LUCENE-3591
> URL: https://issues.apache.org/jira/browse/LUCENE-3591
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3591.patch, LUCENE-3591.patch
>
>
> currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values we can still open this up if it is needed by other packages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long]
package private for DocValues
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3591:
------------------------------------
Attachment: LUCENE-3591.patch
moved the asInt, asLong, asShort counterparts into BytesRefUtils too. Currently only used in the test but nice for consistency.
I will commit this later today
> Make BytesRef.copy[Int,Short,Long] package private for DocValues
> ----------------------------------------------------------------
>
> Key: LUCENE-3591
> URL: https://issues.apache.org/jira/browse/LUCENE-3591
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3591.patch, LUCENE-3591.patch
>
>
> currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values we can still open this up if it is needed by other packages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3591) Make BytesRef.copy[Int,Short,Long]
package private for DocValues
Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-3591:
------------------------------------
Attachment: LUCENE-3591.patch
here is a patch moving this into pkg private BytesRefUtils
> Make BytesRef.copy[Int,Short,Long] package private for DocValues
> ----------------------------------------------------------------
>
> Key: LUCENE-3591
> URL: https://issues.apache.org/jira/browse/LUCENE-3591
> Project: Lucene - Java
> Issue Type: Sub-task
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3591.patch
>
>
> currently the BytesRef.copy[Int,Short,Long] api is only used by IndexDocValues and it seems it is pretty unique. I think we should move this into a package private class in o.a.l.i.values we can still open this up if it is needed by other packages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org