You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/12/20 10:30:11 UTC
[GitHub] [age] df7cb opened a new pull request, #398: Fix agtype_btree_cmp test in C.UTF-8 locale
df7cb opened a new pull request, #398:
URL: https://github.com/apache/age/pull/398
When running with LC_COLLATE=C.UTF-8, agtype_btree_cmp returns -32 instead of -1. This is a valid return code, so adjust the test to allow that.
```
--- /home/cbe/projects/postgresql/age/age.git/./regress/expected/agtype.out 2022-12-14 14:42:30.512908027 +0100 +++ /home/cbe/projects/postgresql/age/age.git/./regress/results/agtype.out 2022-12-20 11:24:07.437053056 +0100 @@ -2886,7 +2886,7 @@
SELECT agtype_btree_cmp('"string"'::agtype, '"string "'::agtype);
agtype_btree_cmp
------------------
- -1
+ -32
(1 row)
SELECT agtype_btree_cmp(NULL, NULL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #398: Fix agtype_btree_cmp test in C.UTF-8 locale
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #398:
URL: https://github.com/apache/age/pull/398#issuecomment-1360440639
@df7cb Thank you for the PR! However, this has already been addressed in the master and PG12 branches -
```
commit dd34ea51d8e22b2008c3c2af9da5968ec2e95eaa
Author: John Gemignani <jr...@gmail.com>
Date: Wed Dec 14 13:10:07 2022 -0800
Fix compare_agtype_scalar_values returned result
Fixed compare_agtype_scalar_values returned result. It used a
function, varstr_cmp, that wasn't guaranteed to return 1, 0, or -1.
It was only guaranteed to return >0, 0, or <0. This caused some
builds to fail during the regression tests, as 1, 0, or -1 were
expected.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] df7cb closed pull request #398: Fix agtype_btree_cmp test in C.UTF-8 locale
Posted by GitBox <gi...@apache.org>.
df7cb closed pull request #398: Fix agtype_btree_cmp test in C.UTF-8 locale
URL: https://github.com/apache/age/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] jrgemignani commented on pull request #398: Fix agtype_btree_cmp test in C.UTF-8 locale
Posted by GitBox <gi...@apache.org>.
jrgemignani commented on PR #398:
URL: https://github.com/apache/age/pull/398#issuecomment-1361826986
No problem, it happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [age] df7cb commented on pull request #398: Fix agtype_btree_cmp test in C.UTF-8 locale
Posted by GitBox <gi...@apache.org>.
df7cb commented on PR #398:
URL: https://github.com/apache/age/pull/398#issuecomment-1361752537
Ah ok, I was using the last released version. Should have checked that, sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org