You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2017/03/03 20:40:10 UTC

hbase git commit: HBASE-17722 Metrics subsystem stop/start messages add a lot of useless bulk to operational logging

Repository: hbase
Updated Branches:
  refs/heads/master d3bf24642 -> 404a2883f


HBASE-17722 Metrics subsystem stop/start messages add a lot of useless bulk to operational logging


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/404a2883
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/404a2883
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/404a2883

Branch: refs/heads/master
Commit: 404a2883f2f68f0c2762c0df62a29aebeb7da151
Parents: d3bf246
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Mar 3 12:31:00 2017 -0800
Committer: Andrew Purtell <ap...@apache.org>
Committed: Fri Mar 3 12:40:06 2017 -0800

----------------------------------------------------------------------
 conf/log4j.properties                                        | 5 +++++
 .../hbase-client-project/src/main/resources/log4j.properties | 5 +++++
 .../src/main/resources/log4j.properties                      | 5 +++++
 hbase-client/src/test/resources/log4j.properties             | 8 +++++---
 hbase-common/src/test/resources/log4j.properties             | 8 +++++---
 hbase-examples/src/test/resources/log4j.properties           | 8 +++++---
 hbase-prefix-tree/src/test/resources/log4j.properties        | 8 +++++---
 hbase-procedure/src/test/resources/log4j.properties          | 8 +++++---
 hbase-rest/src/test/resources/log4j.properties               | 8 +++++---
 hbase-server/src/test/resources/log4j.properties             | 8 +++++---
 hbase-shell/src/test/resources/log4j.properties              | 8 +++++---
 hbase-spark/src/test/resources/log4j.properties              | 8 +++++---
 12 files changed, 60 insertions(+), 27 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/conf/log4j.properties
----------------------------------------------------------------------
diff --git a/conf/log4j.properties b/conf/log4j.properties
index 293386a..a6a560e 100644
--- a/conf/log4j.properties
+++ b/conf/log4j.properties
@@ -116,3 +116,8 @@ log4j.logger.org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher=INFO
 # Add "EventCounter" to rootlogger if you want to use this
 # Uncomment the line below to add EventCounter information
 # log4j.appender.EventCounter=org.apache.hadoop.log.metrics.EventCounter
+
+# Prevent metrics subsystem start/stop messages (HBASE-17722)
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-archetypes/hbase-client-project/src/main/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-archetypes/hbase-client-project/src/main/resources/log4j.properties b/hbase-archetypes/hbase-client-project/src/main/resources/log4j.properties
index 2475ea0..11f2b75 100644
--- a/hbase-archetypes/hbase-client-project/src/main/resources/log4j.properties
+++ b/hbase-archetypes/hbase-client-project/src/main/resources/log4j.properties
@@ -114,3 +114,8 @@ log4j.logger.org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher=INFO
 # Add "EventCounter" to rootlogger if you want to use this
 # Uncomment the line below to add EventCounter information
 # log4j.appender.EventCounter=org.apache.hadoop.log.metrics.EventCounter
+
+# Prevent metrics subsystem start/stop messages (HBASE-17722)
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-archetypes/hbase-shaded-client-project/src/main/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-archetypes/hbase-shaded-client-project/src/main/resources/log4j.properties b/hbase-archetypes/hbase-shaded-client-project/src/main/resources/log4j.properties
index 2475ea0..11f2b75 100644
--- a/hbase-archetypes/hbase-shaded-client-project/src/main/resources/log4j.properties
+++ b/hbase-archetypes/hbase-shaded-client-project/src/main/resources/log4j.properties
@@ -114,3 +114,8 @@ log4j.logger.org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher=INFO
 # Add "EventCounter" to rootlogger if you want to use this
 # Uncomment the line below to add EventCounter information
 # log4j.appender.EventCounter=org.apache.hadoop.log.metrics.EventCounter
+
+# Prevent metrics subsystem start/stop messages (HBASE-17722)
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-client/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-client/src/test/resources/log4j.properties b/hbase-client/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-client/src/test/resources/log4j.properties
+++ b/hbase-client/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-common/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-common/src/test/resources/log4j.properties b/hbase-common/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-common/src/test/resources/log4j.properties
+++ b/hbase-common/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-examples/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-examples/src/test/resources/log4j.properties b/hbase-examples/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-examples/src/test/resources/log4j.properties
+++ b/hbase-examples/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-prefix-tree/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-prefix-tree/src/test/resources/log4j.properties b/hbase-prefix-tree/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-prefix-tree/src/test/resources/log4j.properties
+++ b/hbase-prefix-tree/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-procedure/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-procedure/src/test/resources/log4j.properties b/hbase-procedure/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-procedure/src/test/resources/log4j.properties
+++ b/hbase-procedure/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-rest/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-rest/src/test/resources/log4j.properties b/hbase-rest/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-rest/src/test/resources/log4j.properties
+++ b/hbase-rest/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-server/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/resources/log4j.properties b/hbase-server/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-server/src/test/resources/log4j.properties
+++ b/hbase-server/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-shell/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-shell/src/test/resources/log4j.properties b/hbase-shell/src/test/resources/log4j.properties
index 4eeeb2c..c322699 100644
--- a/hbase-shell/src/test/resources/log4j.properties
+++ b/hbase-shell/src/test/resources/log4j.properties
@@ -58,9 +58,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE

http://git-wip-us.apache.org/repos/asf/hbase/blob/404a2883/hbase-spark/src/test/resources/log4j.properties
----------------------------------------------------------------------
diff --git a/hbase-spark/src/test/resources/log4j.properties b/hbase-spark/src/test/resources/log4j.properties
index 6d9415b..cd3b8e9 100644
--- a/hbase-spark/src/test/resources/log4j.properties
+++ b/hbase-spark/src/test/resources/log4j.properties
@@ -66,9 +66,11 @@ log4j.logger.org.apache.hadoop=WARN
 log4j.logger.org.apache.zookeeper=ERROR
 log4j.logger.org.apache.hadoop.hbase=DEBUG
 
-#These two settings are workarounds against spurious logs from the minicluster.
+#These settings are workarounds against spurious logs from the minicluster.
 #See HBASE-4709
-log4j.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=ERROR
-log4j.org.apache.hadoop.metrics2.util.MBeans=ERROR
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsConfig=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSinkAdapter=WARN
+log4j.logger.org.apache.hadoop.metrics2.impl.MetricsSystemImpl=WARN
+log4j.logger.org.apache.hadoop.metrics2.util.MBeans=WARN
 # Enable this to get detailed connection error/retry logging.
 # log4j.logger.org.apache.hadoop.hbase.client.ConnectionImplementation=TRACE