[jira] [Resolved] (LUCENE-9424) Have a warning comment for AttributeSource.captureState

["Michael McCandless (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-9424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless resolved LUCENE-9424.
----------------------------------------
    Fix Version/s: 8.7
                   master (9.0)
       Resolution: Fixed

Thank you [~zhai7631]!

> Have a warning comment for AttributeSource.captureState
> -------------------------------------------------------
>
>                 Key: LUCENE-9424
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9424
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/javadocs
>            Reporter: Haoyu Zhai
>            Priority: Trivial
>             Fix For: master (9.0), 8.7
>
>         Attachments: LUCENE-9424.patch
>
>
> {{AttributeSource.captureState}} is a powerful method that can be used to store and (later on) restore the current state, but it comes with a cost of copying all attributes in this source and sometimes can be a big cost if called multiple times.
> We could probably add a warning to indicate this cost, as this method is encapsulated quite well and sometimes people who use it won't be aware of the cost.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org