You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/20 09:02:55 UTC
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38726: [SPARK-41203] [CONNECT] Support Dataframe.tansform in Python client.
HyukjinKwon commented on code in PR #38726:
URL: https://github.com/apache/spark/pull/38726#discussion_r1027251817
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
+
+ Parameters
+ ----------
+ func : function
+ a function that takes and returns a :class:`DataFrame`.
+ *args
+ Positional arguments to pass to func.
+
+ .. versionadded:: 3.3.0
Review Comment:
```suggestion
```
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
+
+ Parameters
+ ----------
+ func : function
+ a function that takes and returns a :class:`DataFrame`.
+ *args
+ Positional arguments to pass to func.
+
+ .. versionadded:: 3.3.0
+ **kwargs
+ Keyword arguments to pass to func.
+
+ .. versionadded:: 3.3.0
Review Comment:
```suggestion
```
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -756,6 +757,62 @@ def schema(self) -> StructType:
else:
return self._schema
+ def transform(self, func: Callable[..., "DataFrame"], *args: Any, **kwargs: Any) -> "DataFrame":
+ """Returns a new :class:`DataFrame`. Concise syntax for chaining custom transformations.
+
+ .. versionadded:: 3.0.0
Review Comment:
```suggestion
.. versionadded:: 3.3.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org