I'd like to change verifyAndSet in HiveConf

[Lars Francke <la...@gmail.com>]

Hi,

I've just run into a problem with verifyAndSet in HiveConf. It throws
an exception when someone tries to use a blacklisted property. We've
blacklisted hive.aux.jars.path amongst others.

But we're using the same environment variables for client and server.
With Hadoop this is no problem, it logs a warning when one tries to
override a final parameter but Hive now fails on connection startup
because the client tries to set hive.aux.jars.path making beeline
pretty much unusable.

This only happens since
https://issues.apache.org/jira/browse/HIVE-6340 was fixed as it wasn't
passed on before.

Is there any good reason why we can't change this behavior and instead
of throwing an exception just log and ignore?

I'm happy to create an issue and submit a patch just wanted to ask
first if I'm missing anything.

Cheers,
Lars

Re: I'd like to change verifyAndSet in HiveConf

[Lars Francke <la...@gmail.com>]

I see what you mean. I'm not sure I fully agree but that sounds like
what we do agree on is that something should be changed. I'll open an
issue.

Thanks for your input.

On Thu, May 22, 2014 at 10:17 PM, Thejas Nair <th...@hortonworks.com> wrote:
> If the verifyAndSet in HiveConf is changed to log a warning instead of
> throwing an error, it would mean that any "set
> <blacklisted.property>=abc;" would result in a warning instead of an
> error.
> This would not be the right behavior IMO, a command that did not
> succeed should throw an error.
>
> I think a better approach would be to support ability to have a
> beeline specific property, which if set does not use the common HIVE
> env properties.
>
>
> On Thu, May 22, 2014 at 9:36 AM, Lars Francke <la...@gmail.com> wrote:
>> Hi,
>>
>> I've just run into a problem with verifyAndSet in HiveConf. It throws
>> an exception when someone tries to use a blacklisted property. We've
>> blacklisted hive.aux.jars.path amongst others.
>>
>> But we're using the same environment variables for client and server.
>> With Hadoop this is no problem, it logs a warning when one tries to
>> override a final parameter but Hive now fails on connection startup
>> because the client tries to set hive.aux.jars.path making beeline
>> pretty much unusable.
>>
>> This only happens since
>> https://issues.apache.org/jira/browse/HIVE-6340 was fixed as it wasn't
>> passed on before.
>>
>> Is there any good reason why we can't change this behavior and instead
>> of throwing an exception just log and ignore?
>>
>> I'm happy to create an issue and submit a patch just wanted to ask
>> first if I'm missing anything.
>>
>> Cheers,
>> Lars
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.

Re: I'd like to change verifyAndSet in HiveConf

[Thejas Nair <th...@hortonworks.com>]

If the verifyAndSet in HiveConf is changed to log a warning instead of
throwing an error, it would mean that any "set
<blacklisted.property>=abc;" would result in a warning instead of an
error.
This would not be the right behavior IMO, a command that did not
succeed should throw an error.

I think a better approach would be to support ability to have a
beeline specific property, which if set does not use the common HIVE
env properties.


On Thu, May 22, 2014 at 9:36 AM, Lars Francke <la...@gmail.com> wrote:
> Hi,
>
> I've just run into a problem with verifyAndSet in HiveConf. It throws
> an exception when someone tries to use a blacklisted property. We've
> blacklisted hive.aux.jars.path amongst others.
>
> But we're using the same environment variables for client and server.
> With Hadoop this is no problem, it logs a warning when one tries to
> override a final parameter but Hive now fails on connection startup
> because the client tries to set hive.aux.jars.path making beeline
> pretty much unusable.
>
> This only happens since
> https://issues.apache.org/jira/browse/HIVE-6340 was fixed as it wasn't
> passed on before.
>
> Is there any good reason why we can't change this behavior and instead
> of throwing an exception just log and ignore?
>
> I'm happy to create an issue and submit a patch just wanted to ask
> first if I'm missing anything.
>
> Cheers,
> Lars

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.