You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/14 23:19:15 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request #14150: fix: Center each import icon and add a tooltip
lyndsiWilliams opened a new pull request #14150:
URL: https://github.com/apache/superset/pull/14150
### SUMMARY
I have added a tooltip with text "Import [object]" (example: "Import Database", "Import Dataset", etc.) on all occurrences of the import icon: Database, Dataset, Chart, Dashboard, Saved Query. I have also centered each tooltip icon.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### BEFORE:
<img width="386" alt="import-icon-before" src="https://user-images.githubusercontent.com/55605634/114792120-5dff7f00-9d4d-11eb-9197-ad697d4a8e61.png">
#### AFTER:
<img width="319" alt="import-icon-after" src="https://user-images.githubusercontent.com/55605634/114792148-6657ba00-9d4d-11eb-897d-25799d6d283c.png">
### TEST PLAN
- Navigate to all pages with an import icon (Database, Dataset, Chart, Dashboard, Saved Query)
- Observe that the icon is centered with it's neighboring button(s)
- Hover mouse pointer over the import icon
- Observe the appropriate relative "Import [object]" tooltip
### ADDITIONAL INFORMATION
- [x] Has associated issue: https://github.com/apache/superset/issues/13920
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a change in pull request #14150: fix: Center each import icon and add a tooltip
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on a change in pull request #14150:
URL: https://github.com/apache/superset/pull/14150#discussion_r613712865
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -545,14 +552,24 @@ function ChartList(props: ChartListProps) {
}
if (isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT)) {
subMenuButtons.push({
- name: <Icons.Import />,
+ name: (
+ <Tooltip
+ id="import-tooltip"
+ title={t('Import Chart')}
+ placement="bottomRight"
+ >
+ <Icons.Import />
+ </Tooltip>
+ ),
buttonStyle: 'link',
onClick: openChartImportModal,
});
}
return (
<>
- <SubMenu name={t('Charts')} buttons={subMenuButtons} />
+ <StyledNavbarRight>
Review comment:
Good call, that's a lot cleaner! Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #14150: fix: Center each import icon and add a tooltip
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on pull request #14150:
URL: https://github.com/apache/superset/pull/14150#issuecomment-821167478
Continued at #14192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams closed pull request #14150: fix: Center each import icon and add a tooltip
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams closed pull request #14150:
URL: https://github.com/apache/superset/pull/14150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #14150: fix: Center each import icon and add a tooltip
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #14150:
URL: https://github.com/apache/superset/pull/14150#discussion_r613670789
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -545,14 +552,24 @@ function ChartList(props: ChartListProps) {
}
if (isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT)) {
subMenuButtons.push({
- name: <Icons.Import />,
+ name: (
+ <Tooltip
+ id="import-tooltip"
+ title={t('Import Chart')}
+ placement="bottomRight"
+ >
+ <Icons.Import />
+ </Tooltip>
+ ),
buttonStyle: 'link',
onClick: openChartImportModal,
});
}
return (
<>
- <SubMenu name={t('Charts')} buttons={subMenuButtons} />
+ <StyledNavbarRight>
Review comment:
Does it make sense to just apply these styles to the SubMenu? Seems like the default behavior/expectation is that these items are centered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org