You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/26 13:52:02 UTC
[GitHub] [solr] ErickErickson opened a new pull request #713: SOLR-14920: Format code automatically and enforce it in Solr solrj/st…
ErickErickson opened a new pull request #713:
URL: https://github.com/apache/solr/pull/713
…ream/io
https://issues.apache.org/jira/browse/SOLR-14920 for solrj/stream/io
I went over all the changes and fixed up what looked odd. All tests pass. I'll leave it to others to merge when the time is right.
NOTE: spotless.gradle will need to be resolved since I listed everything in solrj _except_ stream/io in the targetExclude list. That should just be deleting the entire case though once all the other solrj code is checked in...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk edited a comment on pull request #713: SOLR-14920: Format code automatically and enforce it in Solr solrj/st…
Posted by GitBox <gi...@apache.org>.
risdenk edited a comment on pull request #713:
URL: https://github.com/apache/solr/pull/713#issuecomment-1054362926
Pulled the relevant changes into PR #706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #713: SOLR-14920: Format code automatically and enforce it in Solr solrj/st…
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #713:
URL: https://github.com/apache/solr/pull/713#discussion_r815349735
##########
File path: solr/.idea/.gitignore
##########
@@ -0,0 +1,3 @@
+# Default ignored files
Review comment:
Let's not add such in a PR about indentation
##########
File path: solr/.idea/gradle.xml
##########
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
accidentally added?
##########
File path: solr/.idea/vcs.xml
##########
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
accidentally added?
##########
File path: solr/.idea/misc.xml
##########
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
accidentally added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk closed pull request #713: SOLR-14920: Format code automatically and enforce it in Solr solrj/st…
Posted by GitBox <gi...@apache.org>.
risdenk closed pull request #713:
URL: https://github.com/apache/solr/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #713: SOLR-14920: Format code automatically and enforce it in Solr solrj/st…
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #713:
URL: https://github.com/apache/solr/pull/713#issuecomment-1054349325
Thanks @ErickErickson! I can pull these specific changes into #706 to have it all in one commit at the end. I'll cherry pick these changes over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #713: SOLR-14920: Format code automatically and enforce it in Solr solrj/st…
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #713:
URL: https://github.com/apache/solr/pull/713#issuecomment-1054362926
Pulled the relevant changes into PR #706 706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org