You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "ArnavBalyan (via GitHub)" <gi...@apache.org> on 2025/09/26 07:29:46 UTC
[PR] GH-3317: Fix bytes written by VariantBuilder.appendFloat [parquet-java]
ArnavBalyan opened a new pull request, #3334:
URL: https://github.com/apache/parquet-java/pull/3334
### Rationale for this change
- Fixed the bug by correcting the bytes written value to 4 in VariantBuilder.appendFloat()
- Added test to ensure we only write 5 bytes into the buffer (1 header + 4 float)
- Should prevent any over-indexing the buffer
### Are these changes tested?
- Yes
### Are there any user-facing changes?
- Yes
Closes: #3317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3317: Fix bytes written by VariantBuilder.appendFloat [parquet-java]
Posted by "ArnavBalyan (via GitHub)" <gi...@apache.org>.
ArnavBalyan commented on PR #3334:
URL: https://github.com/apache/parquet-java/pull/3334#issuecomment-3339777193
cc @gszadovszky could you pls take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org
Re: [PR] GH-3317: Fix bytes written by VariantBuilder.appendFloat [parquet-java]
Posted by "gszadovszky (via GitHub)" <gi...@apache.org>.
gszadovszky merged PR #3334:
URL: https://github.com/apache/parquet-java/pull/3334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org