You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/20 23:27:59 UTC

[kudu-CR] [macos] fix build

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12818


Change subject: [macos] fix build
......................................................................

[macos] fix build

This is a follow-up to 39f4637559ac29791cc385308bd63d77a5f18e56.

Change-Id: I6566d08de063676a8f810b63bcb8dfc7863c090b
---
M src/kudu/cfile/block_cache.cc
M src/kudu/util/cache-test.cc
2 files changed, 8 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/12818/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6566d08de063676a8f810b63bcb8dfc7863c090b
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [macos] fix build

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12818 )

Change subject: [macos] fix build
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6566d08de063676a8f810b63bcb8dfc7863c090b
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 23:48:25 +0000
Gerrit-HasComments: No

[kudu-CR] [macos] fix build

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12818 )

Change subject: [macos] fix build
......................................................................

[macos] fix build

This is a follow-up to 39f4637559ac29791cc385308bd63d77a5f18e56.

Change-Id: I6566d08de063676a8f810b63bcb8dfc7863c090b
Reviewed-on: http://gerrit.cloudera.org:8080/12818
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/cfile/block_cache.cc
M src/kudu/util/cache-test.cc
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6566d08de063676a8f810b63bcb8dfc7863c090b
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [macos] fix build

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12818 )

Change subject: [macos] fix build
......................................................................


Patch Set 1:

Thank you review!


-- 
To view, visit http://gerrit.cloudera.org:8080/12818
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6566d08de063676a8f810b63bcb8dfc7863c090b
Gerrit-Change-Number: 12818
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 00:23:54 +0000
Gerrit-HasComments: No