You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/24 23:54:01 UTC
Review Request 27165: Add ns::pid::destroy() to destroy a pid
namespace.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27165/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
All processes are signalled with SIGKILL then reaped. The order of
signalling is not determined, i.e., generally the init pid is not the
first pid signalled.
Diffs
-----
src/linux/ns.hpp PRE-CREATION
src/tests/ns_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/27165/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 27165: Add ns::pid::destroy() to destroy a pid
namespace.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27165/#review58430
-----------------------------------------------------------
Bad patch!
Reviews applied: [27091, 27091]
Failed command: ./support/apply-review.sh -n -r 27091
Error:
2014-10-24 23:11:12 URL:https://reviews.apache.org/r/27091/diff/raw/ [16720/16720] -> "27091.patch" [1]
error: patch failed: src/Makefile.am:406
error: src/Makefile.am: patch does not apply
error: src/linux/ns.hpp: already exists in index
error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:45
error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply
error: src/tests/ns_tests.cpp: already exists in index
error: src/tests/setns_test_helper.hpp: already exists in index
error: src/tests/setns_test_helper.cpp: already exists in index
Failed to apply patch
- Mesos ReviewBot
On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27165/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> All processes are signalled with SIGKILL then reaped. The order of
> signalling is not determined, i.e., generally the init pid is not the
> first pid signalled.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp PRE-CREATION
> src/tests/ns_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27165/diff/
>
>
> Testing
> -------
>
> make check # new test added
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 27165: Add ns::pid::destroy() to destroy a pid
namespace.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27165/#review58441
-----------------------------------------------------------
Ship it!
src/linux/ns.hpp
<https://reviews.apache.org/r/27165/#comment99446>
Can you hide this in an internal namespace?
This can just return Nothing directly.
src/linux/ns.hpp
<https://reviews.apache.org/r/27165/#comment99451>
Can you move this above the call to getns?
src/tests/ns_tests.cpp
<https://reviews.apache.org/r/27165/#comment99459>
children
src/tests/ns_tests.cpp
<https://reviews.apache.org/r/27165/#comment99461>
Can we use ROOT?
- Ben Mahler
On Oct. 24, 2014, 9:54 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27165/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> All processes are signalled with SIGKILL then reaped. The order of
> signalling is not determined, i.e., generally the init pid is not the
> first pid signalled.
>
>
> Diffs
> -----
>
> src/linux/ns.hpp PRE-CREATION
> src/tests/ns_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27165/diff/
>
>
> Testing
> -------
>
> make check # new test added
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 27165: Add ns::pid::destroy() to destroy a pid
namespace.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27165/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 2:54 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
All processes are signalled with SIGKILL then reaped. The order of
signalling is not determined, i.e., generally the init pid is not the
first pid signalled.
Diffs
-----
src/linux/ns.hpp PRE-CREATION
src/tests/ns_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/27165/diff/
Testing (updated)
-------
make check # new test added
Thanks,
Ian Downes