[GitHub] erisu opened a new pull request #376: Fixed Get Apple OSX Version method

[GitBox <gi...@apache.org>]

erisu opened a new pull request #376: Fixed Get Apple OSX Version method
URL: https://github.com/apache/cordova-ios/pull/376
 
 
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   While working on an upcoming PR (#...) for improving the test coverage, I noticed that the `get_apple_osx_version` method has been returning `undefined`. 
   
   After further investigation, the RegEx pattern has been looking for OSX SDK version `OS X` no longer exists since Xcode 8+ 
   
   Example print outs:
   **Xcode 7.3:** https://travis-ci.org/erisu/macos-test/jobs/395785417
   **Xcode 8:** https://travis-ci.org/erisu/macos-test/jobs/395785418
   **For other versions:** https://travis-ci.org/erisu/macos-test/builds/395785415
   
   From the above print out, I determined that the RegEx pattern should be updated to `macOS`
   
   ### What testing has been done on this change?
   - https://travis-ci.org/erisu/cordova-ios/builds/395835801
   - https://ci.appveyor.com/project/erisu/cordova-ios/build/1.0.3
   
   **Note:** Oddly Node 4 appears to be failing but I have submitted PR #375 to drop Node 4 support.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org