You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/05/23 07:07:59 UTC
Review Request 21839: Added metrics for acknowledgement messages in the
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21839/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon and Vinod Kone.
Bugs: MESOS-1411
https://issues.apache.org/jira/browse/MESOS-1411
Repository: mesos-git
Description
-------
This is part 3 of MESOS-1411.
Since we're adding a new message in the master, this adds the corresponding metrics.
Diffs
-----
src/master/master.hpp 99c70631ba10e8811ab0011881f30134c4d0373c
src/master/master.cpp e5d8edf4db932e2c48756df67750b02bbff59c55
src/tests/master_tests.cpp b0e05de9a7226ee330007a3f3fe71976fb0748d6
Diff: https://reviews.apache.org/r/21839/diff/
Testing
-------
Updated the existing metrics test.
Thanks,
Ben Mahler
Re: Review Request 21839: Added metrics for acknowledgement messages in the
master.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21839/#review43986
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On May 22, 2014, 10:07 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21839/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 10:07 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1411
> https://issues.apache.org/jira/browse/MESOS-1411
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 3 of MESOS-1411.
>
> Since we're adding a new message in the master, this adds the corresponding metrics.
>
>
> Diffs
> -----
>
> src/master/master.hpp 99c70631ba10e8811ab0011881f30134c4d0373c
> src/master/master.cpp e5d8edf4db932e2c48756df67750b02bbff59c55
> src/tests/master_tests.cpp b0e05de9a7226ee330007a3f3fe71976fb0748d6
>
> Diff: https://reviews.apache.org/r/21839/diff/
>
>
> Testing
> -------
>
> Updated the existing metrics test.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 21839: Added metrics for acknowledgement messages in the
master.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21839/#review43864
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 23, 2014, 5:07 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21839/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 5:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Vinod Kone.
>
>
> Bugs: MESOS-1411
> https://issues.apache.org/jira/browse/MESOS-1411
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is part 3 of MESOS-1411.
>
> Since we're adding a new message in the master, this adds the corresponding metrics.
>
>
> Diffs
> -----
>
> src/master/master.hpp 99c70631ba10e8811ab0011881f30134c4d0373c
> src/master/master.cpp e5d8edf4db932e2c48756df67750b02bbff59c55
> src/tests/master_tests.cpp b0e05de9a7226ee330007a3f3fe71976fb0748d6
>
> Diff: https://reviews.apache.org/r/21839/diff/
>
>
> Testing
> -------
>
> Updated the existing metrics test.
>
>
> Thanks,
>
> Ben Mahler
>
>