You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by se...@apache.org on 2019/01/23 00:54:05 UTC
[hbase] branch branch-2 updated: HBASE-21575 : memstore above high
watermark message is logged too much
This is an automated email from the ASF dual-hosted git repository.
sershe pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2 by this push:
new 96b98da HBASE-21575 : memstore above high watermark message is logged too much
96b98da is described below
commit 96b98da19da305983fc94301fc2be671560ea7b7
Author: Sergey Shelukhin <se...@apache.org>
AuthorDate: Wed Dec 12 11:02:25 2018 -0800
HBASE-21575 : memstore above high watermark message is logged too much
---
.../org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
index b8c8051..134cbae 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
@@ -698,6 +698,7 @@ class MemStoreFlusher implements FlushRequester {
if (flushType != FlushType.NORMAL) {
TraceUtil.addTimelineAnnotation("Force Flush. We're above high water mark.");
long start = EnvironmentEdgeManager.currentTime();
+ long nextLogTimeMs = start;
synchronized (this.blockSignal) {
boolean blocked = false;
long startTime = 0;
@@ -739,8 +740,11 @@ class MemStoreFlusher implements FlushRequester {
LOG.warn("Interrupted while waiting");
interrupted = true;
}
- long took = EnvironmentEdgeManager.currentTime() - start;
- LOG.warn("Memstore is above high water mark and block " + took + "ms");
+ long nowMs = EnvironmentEdgeManager.currentTime();
+ if (nowMs >= nextLogTimeMs) {
+ LOG.warn("Memstore is above high water mark and block {} ms", nowMs - start);
+ nextLogTimeMs = nowMs + 1000;
+ }
flushType = isAboveHighWaterMark();
}
} finally {