You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/23 09:47:24 UTC
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9284: [3.0] save current rpc service context to url at the beginning of invocation to support LazyConnectExchangeClient and avoid NPE
codecov-commenter edited a comment on pull request #9284:
URL: https://github.com/apache/dubbo/pull/9284#issuecomment-970238275
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9284](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a012815) into [3.0](https://codecov.io/gh/apache/dubbo/commit/858f8a95a2197337d0dea1c87508384ad525a281?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (858f8a9) will **increase** coverage by `0.57%`.
> The diff coverage is `85.00%`.
> :exclamation: Current head a012815 differs from pull request most recent head 63aae46. Consider uploading reports for the commit 63aae46 to get more accurate results
[](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9284 +/- ##
============================================
+ Coverage 64.70% 65.28% +0.57%
- Complexity 329 340 +11
============================================
Files 1206 1201 -5
Lines 51844 51724 -120
Branches 7716 7723 +7
============================================
+ Hits 33546 33766 +220
+ Misses 14685 14334 -351
- Partials 3613 3624 +11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `36.07% <ø> (-0.41%)` | :arrow_down: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `76.56% <50.00%> (+17.18%)` | :arrow_up: |
| [...o/rpc/cluster/support/MergeableClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9NZXJnZWFibGVDbHVzdGVySW52b2tlci5qYXZh) | `56.32% <66.66%> (ø)` | |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.61% <80.95%> (+0.21%)` | :arrow_up: |
| [...bo/rpc/cluster/support/AbstractClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BYnN0cmFjdENsdXN0ZXJJbnZva2VyLmphdmE=) | `79.02% <100.00%> (-0.85%)` | :arrow_down: |
| [...o/rpc/cluster/support/AvailableClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9BdmFpbGFibGVDbHVzdGVySW52b2tlci5qYXZh) | `71.42% <100.00%> (ø)` | |
| [...o/rpc/cluster/support/BroadcastClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Ccm9hZGNhc3RDbHVzdGVySW52b2tlci5qYXZh) | `68.88% <100.00%> (-0.68%)` | :arrow_down: |
| [...bo/rpc/cluster/support/FailfastClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsZmFzdENsdXN0ZXJJbnZva2VyLmphdmE=) | `93.33% <100.00%> (ø)` | |
| [...bo/rpc/cluster/support/FailoverClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsb3ZlckNsdXN0ZXJJbnZva2VyLmphdmE=) | `98.03% <100.00%> (-0.04%)` | :arrow_down: |
| [...bo/rpc/cluster/support/FailsafeClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsc2FmZUNsdXN0ZXJJbnZva2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [156 more](https://codecov.io/gh/apache/dubbo/pull/9284/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [858f8a9...63aae46](https://codecov.io/gh/apache/dubbo/pull/9284?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org