You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/08 18:43:36 UTC
[GitHub] [spark] holdenk commented on a change in pull request #29719: [SPARK-32846][SQL][PYTHON] Support createDataFrame from an RDD of pd.DataFrames
holdenk commented on a change in pull request #29719:
URL: https://github.com/apache/spark/pull/29719#discussion_r666436892
##########
File path: python/pyspark/sql/pandas/conversion.py
##########
@@ -297,8 +297,11 @@ class SparkConversionMixin(object):
"""
Min-in for the conversion from pandas to Spark. Currently, only :class:`SparkSession`
can use this class.
+ pandasRDD=True creates a DataFrame from an RDD of pandas dataframes
+ (currently only supported using arrow)
Review comment:
That's a good point. If we look in `session.py` we can see _createFromRDD does it magic there. Personally I would put this logic instead inside of `_inferSchema` and `toInternal` respectively but I'm coming at this from more a core-spark dev perspective maybe @HyukjinKwon has a different view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org