You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/06 14:49:36 UTC
[GitHub] [incubator-kyuubi] cxzl25 opened a new pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
cxzl25 opened a new pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048
### _Why are the changes needed?_
Support more MySQL JDBC driver versions.
The user may use the 5.x mysql driver to connect to the kyuubi server.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059989695
> Could not find artifact org.apache.kyuubi:kyuubi-XXX_2.12:jar:1.6.0-SNAPSHOT in apache.snapshots
apache snapshot does not have deploy 1.6 version, causing UT to fail.
https://repository.apache.org/content/groups/snapshots/org/apache/kyuubi/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059980949
> May be I missed the previous discussion.
Sorry, it happened in offline discussion.
Don't hesitate if you think we need to introduce antlr deps, even now we don't have detail design of the Kyuubi dialect SQL grammar, but I need some intuitive commands like `SHOW ENGINES`, `SHOW SESSIONS`, and we also need to implement a basic single table `SELECT ... FROM ... WHERE ... LIMIT ... OFFSET ...` for MySQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059977036
[mysql_init_select.sql.txt](https://github.com/apache/incubator-kyuubi/files/8192825/mysql_init_select.sql.txt)
Grab the initialization sql of mysql-connector-java version from 5.1.20 to 8.0.28, and get the parameter list after deduplication.
```
@@auto_increment_increment
@@character_set_client
@@character_set_connection
@@character_set_results
@@character_set_server
@@collation_connection
@@collation_server
@@have_query_cache
@@init_connect
@@interactive_timeout
@@license
@@lower_case_table_names
@@max_allowed_packet
@@net_buffer_length
@@net_write_timeout
@@performance_schema
@@query_cache_size
@@query_cache_type
@@sql_mode
@@system_time_zone
@@time_zone
@@transaction_isolation
@@tx_isolation
@@wait_timeout
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1060127797
Thanks, merging to master/1.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059977304
> The current approach is fragile, it should be replaced by antlr based SQL parser eventually.
Yes, I tried to use the mysql protocol on Friday and encountered this problem, and I also considered whether to consider introducing antlr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059979143
> Kyuubi will introduce Antlr eventually, we have a prototype discussion previously, we'd like to introduce some Kyuubi defined SQL-like grammer, e.g. `SHOW ENGINES [LIKE ...]`, `ALTER SESSION SET ...`, it's something like [ShardingSphere DistSQL](https://github.com/apache/shardingsphere/releases)
Make sense.
May be I missed the previous discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059978289
Kyuubi will introduce Antlr eventually, we have a prototype discussion previously, we'd like to introduce some Kyuubi defined SQL-like grammer, e.g. `SHOW ENGINES [LIKE ...]`, `ALTER SESSION SET ...`, it's something like [ShardingSphere DistSQL](https://github.com/apache/shardingsphere/releases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059980949
> May be I missed the previous discussion.
Sorry, it happened in an offline discussion.
Don't hesitate if you think we need to introduce antlr deps, even now we don't have detail design of the Kyuubi dialect SQL grammar, but I'm sure we need some intuitive commands like `SHOW ENGINES`, `SHOW SESSIONS`, and we also need to implement a basic single table `SELECT ... FROM ... WHERE ... LIMIT ... OFFSET ...` for MySQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059980949
> May be I missed the previous discussion.
Sorry, it happened in offline discussion.
Don't hesitate if you think we need to introduce antlr deps, even now we don't have detail design of the Kyuubi dialect SQL grammar, but I'm sure we need some intuitive commands like `SHOW ENGINES`, `SHOW SESSIONS`, and we also need to implement a basic single table `SELECT ... FROM ... WHERE ... LIMIT ... OFFSET ...` for MySQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059983386
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2048](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03cd15f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/abf2026816ffd707e2c353420749892ff3f01f3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abf2026) will **increase** coverage by `0.04%`.
> The diff coverage is `87.17%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2048 +/- ##
============================================
+ Coverage 60.38% 60.43% +0.04%
Complexity 69 69
============================================
Files 305 305
Lines 14909 14946 +37
Branches 1928 1932 +4
============================================
+ Hits 9003 9032 +29
- Misses 5146 5150 +4
- Partials 760 764 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/kyuubi/server/mysql/MySQLDialectHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxEaWFsZWN0SGVscGVyLnNjYWxh) | `64.40% <87.17%> (+37.13%)` | :arrow_up: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.41% <0.00%> (+0.14%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [abf2026...03cd15f](https://codecov.io/gh/apache/incubator-kyuubi/pull/2048?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #2048: [KYUUBI #2047] Support more MySQL JDBC driver versions
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #2048:
URL: https://github.com/apache/incubator-kyuubi/pull/2048#issuecomment-1059990134
> Don't hesitate if you think we need to introduce antlr deps, even now we don't have detail design of the Kyuubi dialect SQL grammar, but I'm sure we need some intuitive commands like `SHOW ENGINES`, `SHOW SESSIONS`, and we also need to implement a basic single table `SELECT ... FROM ... WHERE ... LIMIT ... OFFSET ...` for MySQL.
ok, I will continue to pay attention to the development of the kyuubi project and see what I can do, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org