code review (was: Re: [Axis2] Re: svn commit: r504063 - in /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2: client/ context/ description/)

[Sanjiva Weerawarana <sa...@opensource.lk>]

+1 indeed! 

However, for community health, let's everyone please be a bit tolerant /
patient / extra polite when asking the other to review/correct. I'm
referring to the tone of the emails .. we're all here to make axis2
great so there's no need to assume otherwise from anyone. (Yes this goes
for me too!)

After all we have Hani look after us to really pick on any mistakes we
make.

Sanjiva.

On Wed, 2007-02-07 at 11:24 +0530, Deepal Jayasinghe wrote:
> Hi Bill;
> 
> I will revert that change since that not going to cost me :)
> Btw I am very happy the current approach , every one looking at the
> commiter messages and going through them, it definitely help to improve
> the code quality
> 
> Thanks
> Deepal
> 
> Deepal Jayasinghe wrote:
> 
> >Hi Bill;
> >
> >Well you can -1 if I have done something wrong (please go ahead and
> >revert if I have done smt wrong), but the changes that I did was not bad
> >as what I fixed in the code base.
> >(http://marc.theaimsgroup.com/?l=axis-cvs&m=117075720119300&w=2)
> >
> >Dint you see the code like following in the MessagConetxt ,
> > if  (operationContext != null) {
> >       if ((operationContext!=null) && (serviceContext != null)
> >
> >So is that the readability you are talking about :)
> >
> >Bill Nagy wrote:
> >
> >  
> >
> >>Whoa, don't have a conniption there.  I hate to point this out, but
> >>changes like this:
> >>
> >>On Tue, 2007-02-06 at 10:19 +0000, deepal@apache.org wrote:
> >> 
> >>
> >>    
> >>
> >>>-        if (selfManagedDataMap != null) {
> >>>-            return
> >>>selfManagedDataMap.containsKey(generateSelfManagedDataKey(clazz,
> >>>key));
> >>>-        }
> >>>-        return false;
> >>>+        return selfManagedDataMap != null &&
> >>>selfManagedDataMap.containsKey
> >>>+                (generateSelfManagedDataKey(clazz, key)); 
> >>>   
> >>>
> >>>      
> >>>
> >>are bad software engineering -- in case that you missed it, compilers
> >>have been improved to allow developers to actually write code in a
> >>readable fashion (yes, even for small devices.)  Repeat after me,
> >>verbosity (including accurate comments) is good software engineering and
> >>allows the code to be more easily understood and bugs caught more
> >>quickly -- the compiler will optimize. 
> >>
> >>So, -1.
> >>
> >>BTW, please fix your editor to stop altering what I assume to be
> >>whitespace.
> >>
> >>    
> >>
> >Yes , there was a issues with the editor and now I have fixed that.
> >
> >Thanks
> >Deepal
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> >For additional commands, e-mail: axis-cvs-help@ws.apache.org
> >
> >
> >
> >  
> >
> 
-- 
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org