You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Yi Tang (JIRA)" <ji...@apache.org> on 2014/12/01 05:46:12 UTC
[jira] [Updated] (QPID-6251) socket.error raised in writeable is
not transformed to 'ConnectionError' which will cause catch omitted in
upper layer
[ https://issues.apache.org/jira/browse/QPID-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yi Tang updated QPID-6251:
--------------------------
Description:
when calling {{writeable}}, the exception {{socket.error}} is not transformed to {{ConnectionError}} which will cause catch omitted in upper layer
the follow patch should fix it:
{code}
Index: qpid/messaging/driver.py
===================================================================
--- qpid/messaging/driver.py (revision 1642638)
+++ qpid/messaging/driver.py (working copy)
@@ -474,7 +474,7 @@
sent = self.engine.read(n)
rawlog.debug("SENT[%s]: %r", self.log_id, sent)
except socket.error, e:
- self.close_engine(e)
+ self.close_engine(ConnectionError(text=str(e)))
notify = True
if self.update_status() or notify:
{code}
was:
when calling {{writeable}}, the exception 'socket.error' is not transformed to {{ConnectionError}} which will cause catch omitted in upper layer
the follow patch should fix it:
{code}
Index: qpid/messaging/driver.py
===================================================================
--- qpid/messaging/driver.py (revision 1642638)
+++ qpid/messaging/driver.py (working copy)
@@ -474,7 +474,7 @@
sent = self.engine.read(n)
rawlog.debug("SENT[%s]: %r", self.log_id, sent)
except socket.error, e:
- self.close_engine(e)
+ self.close_engine(ConnectionError(text=str(e)))
notify = True
if self.update_status() or notify:
{code}
> socket.error raised in writeable is not transformed to 'ConnectionError' which will cause catch omitted in upper layer
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-6251
> URL: https://issues.apache.org/jira/browse/QPID-6251
> Project: Qpid
> Issue Type: Bug
> Components: Python Client
> Affects Versions: 0.26, 0.28, 0.30
> Reporter: Yi Tang
>
> when calling {{writeable}}, the exception {{socket.error}} is not transformed to {{ConnectionError}} which will cause catch omitted in upper layer
> the follow patch should fix it:
> {code}
> Index: qpid/messaging/driver.py
> ===================================================================
> --- qpid/messaging/driver.py (revision 1642638)
> +++ qpid/messaging/driver.py (working copy)
> @@ -474,7 +474,7 @@
> sent = self.engine.read(n)
> rawlog.debug("SENT[%s]: %r", self.log_id, sent)
> except socket.error, e:
> - self.close_engine(e)
> + self.close_engine(ConnectionError(text=str(e)))
> notify = True
>
> if self.update_status() or notify:
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org