You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/10 07:46:22 UTC
[GitHub] [airflow] mingshi-wang opened a new pull request #20781: Fix airflow trigger cli
mingshi-wang opened a new pull request #20781:
URL: https://github.com/apache/airflow/pull/20781
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
The "airflow dag trigger" reports a harmless yet annoying warning message "Calling DAG.create_dagrun() without an explicit data interval is deprecated". The issue can be fixed by setting the `create_dagrun` function argument `data_interval` to the same value as is calculated by the function.
closes: https://github.com/apache/airflow/issues/20579
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mingshi-wang commented on a change in pull request #20781: Fix airflow dag trigger cli
Posted by GitBox <gi...@apache.org>.
mingshi-wang commented on a change in pull request #20781:
URL: https://github.com/apache/airflow/pull/20781#discussion_r780985984
##########
File path: airflow/api/common/trigger_dag.py
##########
@@ -88,6 +88,9 @@ def _trigger_dag(
conf=run_conf,
external_trigger=True,
dag_hash=dag_bag.dags_hash.get(dag_id),
+ data_interval=_dag.timetable.infer_manual_data_interval(
+ run_after=timezone.coerce_datetime(execution_date)
Review comment:
Updated as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20781: Fix airflow dag trigger cli
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20781:
URL: https://github.com/apache/airflow/pull/20781#issuecomment-1008661385
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20781: Fix airflow dag trigger cli
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20781:
URL: https://github.com/apache/airflow/pull/20781#discussion_r780957893
##########
File path: tests/api/client/test_local_client.py
##########
@@ -76,6 +76,7 @@ def test_trigger_dag(self, mock):
conf=None,
external_trigger=True,
dag_hash=ANY,
+ data_interval=ANY,
Review comment:
This should be checkable, can you try to not use `ANY` here (and the one below)?
##########
File path: airflow/api/common/trigger_dag.py
##########
@@ -88,6 +88,9 @@ def _trigger_dag(
conf=run_conf,
external_trigger=True,
dag_hash=dag_bag.dags_hash.get(dag_id),
+ data_interval=_dag.timetable.infer_manual_data_interval(
+ run_after=timezone.coerce_datetime(execution_date)
Review comment:
`execution_date` is never Noen and already aware at this point, so `pendulum.instance()` is probably a better call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mingshi-wang commented on a change in pull request #20781: Fix airflow dag trigger cli
Posted by GitBox <gi...@apache.org>.
mingshi-wang commented on a change in pull request #20781:
URL: https://github.com/apache/airflow/pull/20781#discussion_r780986208
##########
File path: tests/api/client/test_local_client.py
##########
@@ -76,6 +76,7 @@ def test_trigger_dag(self, mock):
conf=None,
external_trigger=True,
dag_hash=ANY,
+ data_interval=ANY,
Review comment:
Sure. I also updated the test to check the value of "dag_hash".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20781: Fix airflow dag trigger cli
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20781:
URL: https://github.com/apache/airflow/pull/20781#discussion_r780957668
##########
File path: airflow/api/common/trigger_dag.py
##########
@@ -88,6 +88,9 @@ def _trigger_dag(
conf=run_conf,
external_trigger=True,
dag_hash=dag_bag.dags_hash.get(dag_id),
+ data_interval=_dag.timetable.infer_manual_data_interval(
+ run_after=timezone.coerce_datetime(execution_date)
Review comment:
`execution_date` is never None and already aware at this point, so `pendulum.instance()` is probably a better call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20781: Fix airflow dag trigger cli
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20781:
URL: https://github.com/apache/airflow/pull/20781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org