You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2011/09/20 18:36:51 UTC
dont use jira ticket numbers in file/method names please
can we please not do this:
wicket/trunk/wicket-core/src/test/java/org/apache/wicket/wicket4066/Wicket4066Test.java
wicket/intercept is a much more descriptive package name
InterceptBackToHomePageTest is a much more descriptive class name
i hate to go to jira to look up what 4066 was when i break this test...
just saying...
thanks,
-igor
Re: dont use jira ticket numbers in file/method names please
Posted by Igor Vaynberg <ig...@gmail.com>.
sure
On Tue, Sep 20, 2011 at 12:33 PM, Martin Grigorov <mg...@apache.org> wrote:
> you asked for something and I asked for something else
> do we have an agreement ? :-)
>
> On Tue, Sep 20, 2011 at 10:21 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>> or copy the relevant bits of the issue into the javadoc of the test...
>>
>> -igor
>>
>> On Tue, Sep 20, 2011 at 11:55 AM, Martin Grigorov <mg...@apache.org> wrote:
>>> OK, I'll rename them.
>>>
>>> Maybe it is just me but I find the information in the tickets very
>>> useful so I'd like also to ask for something - add more information to
>>> tickets' description and link from the test's javadoc to the ticket it
>>> fixes.
>>>
>>> Thanks!
>>>
>>> On Tue, Sep 20, 2011 at 7:36 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>>>> can we please not do this:
>>>>
>>>> wicket/trunk/wicket-core/src/test/java/org/apache/wicket/wicket4066/Wicket4066Test.java
>>>>
>>>> wicket/intercept is a much more descriptive package name
>>>>
>>>> InterceptBackToHomePageTest is a much more descriptive class name
>>>>
>>>> i hate to go to jira to look up what 4066 was when i break this test...
>>>>
>>>> just saying...
>>>>
>>>> thanks,
>>>> -igor
>>>>
>>>
>>>
>>>
>>> --
>>> Martin Grigorov
>>> jWeekend
>>> Training, Consulting, Development
>>> http://jWeekend.com
>>>
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>
Re: dont use jira ticket numbers in file/method names please
Posted by Martin Grigorov <mg...@apache.org>.
you asked for something and I asked for something else
do we have an agreement ? :-)
On Tue, Sep 20, 2011 at 10:21 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> or copy the relevant bits of the issue into the javadoc of the test...
>
> -igor
>
> On Tue, Sep 20, 2011 at 11:55 AM, Martin Grigorov <mg...@apache.org> wrote:
>> OK, I'll rename them.
>>
>> Maybe it is just me but I find the information in the tickets very
>> useful so I'd like also to ask for something - add more information to
>> tickets' description and link from the test's javadoc to the ticket it
>> fixes.
>>
>> Thanks!
>>
>> On Tue, Sep 20, 2011 at 7:36 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>>> can we please not do this:
>>>
>>> wicket/trunk/wicket-core/src/test/java/org/apache/wicket/wicket4066/Wicket4066Test.java
>>>
>>> wicket/intercept is a much more descriptive package name
>>>
>>> InterceptBackToHomePageTest is a much more descriptive class name
>>>
>>> i hate to go to jira to look up what 4066 was when i break this test...
>>>
>>> just saying...
>>>
>>> thanks,
>>> -igor
>>>
>>
>>
>>
>> --
>> Martin Grigorov
>> jWeekend
>> Training, Consulting, Development
>> http://jWeekend.com
>>
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com
Re: dont use jira ticket numbers in file/method names please
Posted by Igor Vaynberg <ig...@gmail.com>.
or copy the relevant bits of the issue into the javadoc of the test...
-igor
On Tue, Sep 20, 2011 at 11:55 AM, Martin Grigorov <mg...@apache.org> wrote:
> OK, I'll rename them.
>
> Maybe it is just me but I find the information in the tickets very
> useful so I'd like also to ask for something - add more information to
> tickets' description and link from the test's javadoc to the ticket it
> fixes.
>
> Thanks!
>
> On Tue, Sep 20, 2011 at 7:36 PM, Igor Vaynberg <ig...@gmail.com> wrote:
>> can we please not do this:
>>
>> wicket/trunk/wicket-core/src/test/java/org/apache/wicket/wicket4066/Wicket4066Test.java
>>
>> wicket/intercept is a much more descriptive package name
>>
>> InterceptBackToHomePageTest is a much more descriptive class name
>>
>> i hate to go to jira to look up what 4066 was when i break this test...
>>
>> just saying...
>>
>> thanks,
>> -igor
>>
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>
Re: dont use jira ticket numbers in file/method names please
Posted by Martin Grigorov <mg...@apache.org>.
OK, I'll rename them.
Maybe it is just me but I find the information in the tickets very
useful so I'd like also to ask for something - add more information to
tickets' description and link from the test's javadoc to the ticket it
fixes.
Thanks!
On Tue, Sep 20, 2011 at 7:36 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> can we please not do this:
>
> wicket/trunk/wicket-core/src/test/java/org/apache/wicket/wicket4066/Wicket4066Test.java
>
> wicket/intercept is a much more descriptive package name
>
> InterceptBackToHomePageTest is a much more descriptive class name
>
> i hate to go to jira to look up what 4066 was when i break this test...
>
> just saying...
>
> thanks,
> -igor
>
--
Martin Grigorov
jWeekend
Training, Consulting, Development
http://jWeekend.com