You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/04 05:10:22 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Pearl1594 opened a new pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564
### Description
This PR allows one to enable network offering during creation
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
Create a network offering specifying if it has to be enabled / not and create network using that offering - verify that the offering is available in the list of available offerings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#discussion_r551123487
##########
File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -5032,8 +5032,12 @@ public NetworkOffering createNetworkOffering(final CreateNetworkOfferingCmd cmd)
forVpc = false;
}
- final NetworkOffering offering = createNetworkOffering(name, displayText, trafficType, tags, specifyVlan, availability, networkRate, serviceProviderMap, false, guestType, false,
+ final NetworkOfferingVO offering = createNetworkOffering(name, displayText, trafficType, tags, specifyVlan, availability, networkRate, serviceProviderMap, false, guestType, false,
serviceOfferingId, conserveMode, serviceCapabilityMap, specifyIpRanges, isPersistent, details, egressDefaultPolicy, maxconn, enableKeepAlive, forVpc, domainIds, zoneIds);
+ if (enable) {
Review comment:
Instead of updating the offeringVO again, pass the value of "enable" to createNetworkOffering() method and use offeringFinal.setState() method to set it while creating the initial VO entry itself.
##########
File path: server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java
##########
@@ -387,14 +387,20 @@ public VpcOffering createVpcOffering(CreateVPCOfferingCmd cmd) {
}
}
- return createVpcOffering(vpcOfferingName, displayText, supportedServices,
+ VpcOfferingVO vpcOfferingVO = createVpcOffering(vpcOfferingName, displayText, supportedServices,
serviceProviderList, serviceCapabilitystList, serviceOfferingId,
domainIds, zoneIds);
+
+ if (enable) {
Review comment:
same as above comment for NetworkOfferingVO. Set it while creating VO itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-777303555
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-777304247
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-777337234
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2677
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-775849350
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-778111728
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-778112193
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-778428042
<b>Trillian test result (tid-3533)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33048 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4564-t3533-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-775804458
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4564: Network Offering: Allow enabling network and vpc offering during creation
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4564:
URL: https://github.com/apache/cloudstack/pull/4564#issuecomment-775804872
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org