You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/09/12 09:48:13 UTC

[GitHub] [nifi] ferencerdei commented on a diff in pull request #6375: NIFI-10458 Add support for the DESCRIBE/MANIFEST Operation

ferencerdei commented on code in PR #6375:
URL: https://github.com/apache/nifi/pull/6375#discussion_r968201180


##########
c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/C2HeartbeatFactory.java:
##########
@@ -225,4 +234,27 @@ private File getConfDirectory() {
 
         return confDirectory;
     }
+
+    private String calculateManifestHash(List<Bundle> loadedBundles) {

Review Comment:
   As more factors will come into play with the new C2 operation implementations, I think it would be better to separate this logic into a class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org