You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2015/06/11 23:08:20 UTC
[jclouds-labs-google] JCLOUDS-935. Move AttachDisk.InitializeParams
to URI for diskType (#153)
Note that two tests are failing right now with or without this.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs-google/pull/153
-- Commit Summary --
* JCLOUDS-935. Move AttachDisk.InitializeParams to URI for diskType
-- File Changes --
M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/AttachDisk.java (4)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/InstanceApiMockTest.java (2)
M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/parse/ParseInstanceTest.java (10)
M google-compute-engine/src/test/resources/instance_attach_disk.json (2)
M google-compute-engine/src/test/resources/instance_get.json (2)
M google-compute-engine/src/test/resources/instance_list.json (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/153.patch
https://github.com/jclouds/jclouds-labs-google/pull/153.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/153
Re: [jclouds-labs-google] JCLOUDS-935. Move
AttachDisk.InitializeParams to URI for diskType (#153)
Posted by Andrew Bayer <no...@github.com>.
The failing tests - https://gist.github.com/abayer/72554e8861873b3f4750 - sometimes they seem to pass, sometimes they don't, and I can't figure out why.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/153#issuecomment-111539176
Re: [jclouds-labs-google] JCLOUDS-935. Move
AttachDisk.InitializeParams to URI for diskType (#153)
Posted by Andrew Bayer <no...@github.com>.
Well that was dumb. I forgot what repo I was in and merged it. Oops. Will push by hand.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/153#issuecomment-111539592
Re: [jclouds-labs-google] JCLOUDS-935. Move
AttachDisk.InitializeParams to URI for diskType (#153)
Posted by Andrew Bayer <no...@github.com>.
Merged #153.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/153#event-329711798
Re: [jclouds-labs-google] JCLOUDS-935. Move
AttachDisk.InitializeParams to URI for diskType (#153)
Posted by Ignasi Barrera <no...@github.com>.
The change lgtm. Which tests are failing? I was able to run the live tests without issues in the current master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/153#issuecomment-111408229