[GitHub] [shardingsphere] menghaoranss commented on a diff in pull request #18398: Remove the check method in ShardingRule.

[GitBox <gi...@apache.org>]

menghaoranss commented on code in PR #18398:
URL: https://github.com/apache/shardingsphere/pull/18398#discussion_r899743222


##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/sharding/distsql/handler/checker/ShardingTableRuleStatementChecker.java:
##########
@@ -98,6 +114,27 @@ private static void check(final ShardingSphereDatabase database,
         Map<String, List<AbstractTableRuleSegment>> groupedTableRule = groupingByClassType(rules);
         checkAutoTableRule(groupedTableRule.getOrDefault(AutoTableRuleSegment.class.getSimpleName(), Collections.emptyList()));
         checkTableRule(databaseName, currentRuleConfig, groupedTableRule.getOrDefault(TableRuleSegment.class.getSimpleName(), Collections.emptyList()));
+        if (!isCreate) {

Review Comment:
   Does the rule need to be checked when binding table rule is created?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org