You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by bc...@apache.org on 2018/05/10 12:56:39 UTC
[trafficserver] branch master updated: Coverity 1267857: Null
return value check in check_request_validity.
This is an automated email from the ASF dual-hosted git repository.
bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
The following commit(s) were added to refs/heads/master by this push:
new e466fdf Coverity 1267857: Null return value check in check_request_validity.
e466fdf is described below
commit e466fdf3a2475b458a5cf499594185c0ee24167f
Author: Steven Feltner <sf...@godaddy.com>
AuthorDate: Wed May 9 09:53:05 2018 -0400
Coverity 1267857: Null return value check in check_request_validity.
---
proxy/http/HttpTransact.cc | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index dcbc551..80a8a0f 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -5080,17 +5080,19 @@ HttpTransact::check_request_validity(State *s, HTTPHdr *incoming_hdr)
// Check for chunked encoding
if (incoming_hdr->presence(MIME_PRESENCE_TRANSFER_ENCODING)) {
MIMEField *field = incoming_hdr->field_find(MIME_FIELD_TRANSFER_ENCODING, MIME_LEN_TRANSFER_ENCODING);
- HdrCsvIter enc_val_iter;
- int enc_val_len;
- const char *enc_value = enc_val_iter.get_first(field, &enc_val_len);
-
- while (enc_value) {
- const char *wks_value = hdrtoken_string_to_wks(enc_value, enc_val_len);
- if (wks_value == HTTP_VALUE_CHUNKED) {
- s->client_info.transfer_encoding = CHUNKED_ENCODING;
- break;
+ if (field) {
+ HdrCsvIter enc_val_iter;
+ int enc_val_len;
+ const char *enc_value = enc_val_iter.get_first(field, &enc_val_len);
+
+ while (enc_value) {
+ const char *wks_value = hdrtoken_string_to_wks(enc_value, enc_val_len);
+ if (wks_value == HTTP_VALUE_CHUNKED) {
+ s->client_info.transfer_encoding = CHUNKED_ENCODING;
+ break;
+ }
+ enc_value = enc_val_iter.get_next(&enc_val_len);
}
- enc_value = enc_val_iter.get_next(&enc_val_len);
}
}
--
To stop receiving notification emails like this one, please contact
bcall@apache.org.