You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by bostko <gi...@git.apache.org> on 2016/11/09 11:18:32 UTC
[GitHub] brooklyn-ui pull request #36: Fix nav menu in Brooklyn API page
GitHub user bostko opened a pull request:
https://github.com/apache/brooklyn-ui/pull/36
Fix nav menu in Brooklyn API page
Previously when you are on the API page dropdown menu was not visible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bostko/brooklyn-ui fix_swagger_menu
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 72f65b279ab6a9579df98f21fe6a324d5560623f
Author: Valentin Aitken <bo...@gmail.com>
Date: 2016-11-09T11:15:40Z
Fix nav menu in swagger page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Fix nav menu in Brooklyn API page
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko could you revisit Alex and Svet's comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Fix nav menu in Brooklyn API page
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@neykov I changed it to open in the same tab.
Can you check again whether it looks consistent UX.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@sjcorbett thanks for the notes!
I added in apache/brooklyn-server#578 an `unauthorize` call which seems to solve the issues in classic mode.
Could you check both PRs again,
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Fix nav menu in Brooklyn API page
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
LGTM. This has been changed back and forth in the past, so @ahgittin, @m4rkmckenna any comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko Looks like this negatively impacts logging out of the non-Karaf distribution. After logging out I've found that:
* master non-karaf: prompts for re-authentication.
* master karaf: 405 error `POST is not supported by this URL`
* this pr karaf: displays page with "login" in big text. Clicking it prompts for re-authentication.
* this pr non-karaf: displays page with "login" in big text. Clicking it logs the user back in without requiring re-authentication.
We should prompt the user to re-authenticate in the standard distribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Fix nav menu in Brooklyn API page
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
I think that's the wrong way to fix the problem. The swagger page is opened with `target=_blank` so it's a separate on from the main application. This makes it surprising - say you click on the rest api page which opens a new tab (you could even miss that), then click back on applications. Now you have to identical tabs.
We should either:
* remove the frame from the swagger page so it's obvious that a new tab is opened. With no way to click on the application tab (which brings even more confusion)
* Open the swagger ui in the same window
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #36: Fix nav menu in Brooklyn API page
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/36#discussion_r89497106
--- Diff: src/main/webapp/assets/html/swagger-ui.html ---
@@ -81,15 +83,15 @@
<a class="logo" href="#" title="Brooklyn, Version 0.10.0-SNAPSHOT"><!-- Logo added via CSS --></a> <!-- BROOKLYN_VERSION -->
--- End diff --
the line 2 above, don't we need to change `href="/logout"` to `href="../../v1/logout"` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #36: Updated logout step to work in karaf mode
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko looks good. Will test and merge if ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Fix nav menu in Brooklyn API page
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui issue #36: Updated logout step to work in karaf mode
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko thanks for the update. I've confirmed that the browser requires re-authentication in both cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #36: Fix nav menu in Brooklyn API page
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/36#discussion_r89504201
--- Diff: src/main/webapp/assets/js/config-swagger.js ---
@@ -0,0 +1,12 @@
+require.config({
--- End diff --
Somehow related, https://github.com/apache/brooklyn-ui/pull/38 activates the rat plugin for the project. So good point about adding license here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request #36: Fix nav menu in Brooklyn API page
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/36#discussion_r89496609
--- Diff: src/main/webapp/assets/js/config-swagger.js ---
@@ -0,0 +1,12 @@
+require.config({
--- End diff --
where is this file used?
does it need the RAT header?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---